From 3c864beb5a155a7be23c3090a54834fabd898a35 Mon Sep 17 00:00:00 2001
From: Behnam Heydarshahi <bhnm@google.com>
Date: Mon, 12 Dec 2022 15:09:20 +0000
Subject: [PATCH] Taller volume dialog slider on taller screens

Length of the vertical volume dialog slider (the one that pops up in response to volume button press) is now proportional to device height

Bug: b/220088292
Test: Manual. Press volume button up/down on a large screen device. Verify the slider is no longer short.

Change-Id: I70dcc2eb6748536f772aaeebd5a3a64be0050f56
---
 .../SystemUI/res/values-h411dp/dimens.xml     | 19 +++++++++++++++++++
 .../SystemUI/res/values-h700dp/dimens.xml     |  3 ++-
 .../SystemUI/res/values-h841dp/dimens.xml     | 19 +++++++++++++++++++
 3 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 packages/SystemUI/res/values-h411dp/dimens.xml
 create mode 100644 packages/SystemUI/res/values-h841dp/dimens.xml

diff --git a/packages/SystemUI/res/values-h411dp/dimens.xml b/packages/SystemUI/res/values-h411dp/dimens.xml
new file mode 100644
index 0000000000000..6b21353d0e556
--- /dev/null
+++ b/packages/SystemUI/res/values-h411dp/dimens.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+  ~ Copyright (C) 2022 The Android Open Source Project
+  ~
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~ you may not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~      http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<resources>
+    <dimen name="volume_row_slider_height">137dp</dimen>
+</resources>
diff --git a/packages/SystemUI/res/values-h700dp/dimens.xml b/packages/SystemUI/res/values-h700dp/dimens.xml
index 055308f177767..39777ab568475 100644
--- a/packages/SystemUI/res/values-h700dp/dimens.xml
+++ b/packages/SystemUI/res/values-h700dp/dimens.xml
@@ -17,4 +17,5 @@
 <resources>
     <!-- Margin above the ambient indication container -->
     <dimen name="ambient_indication_container_margin_top">15dp</dimen>
-</resources>
\ No newline at end of file
+    <dimen name="volume_row_slider_height">177dp</dimen>
+</resources>
diff --git a/packages/SystemUI/res/values-h841dp/dimens.xml b/packages/SystemUI/res/values-h841dp/dimens.xml
new file mode 100644
index 0000000000000..412da199f6b6a
--- /dev/null
+++ b/packages/SystemUI/res/values-h841dp/dimens.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+  ~ Copyright (C) 2022 The Android Open Source Project
+  ~
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~ you may not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~      http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<resources>
+    <dimen name="volume_row_slider_height">237dp</dimen>
+</resources>