From 9d85fd4d1077f1d1107feb59b08ef9ffc7e99ec7 Mon Sep 17 00:00:00 2001 From: Jon Miranda Date: Thu, 17 Dec 2020 17:10:04 +0000 Subject: [PATCH] Fix startPostponedEnterTransition being called too early. Bug: 174811491 Test: consecutive screenshot to share actions Change-Id: Ieb6db02948e22c3a30a0874e0fb5881d249f8641 --- .../android/internal/app/ChooserActivity.java | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/core/java/com/android/internal/app/ChooserActivity.java b/core/java/com/android/internal/app/ChooserActivity.java index e06413783fe4f..34e03af4c6663 100644 --- a/core/java/com/android/internal/app/ChooserActivity.java +++ b/core/java/com/android/internal/app/ChooserActivity.java @@ -431,19 +431,22 @@ public class ChooserActivity extends ResolverActivity implements } private void maybeHideContentPreview() { - if (!mAtLeastOneLoaded && mHideParentOnFail) { - Log.i(TAG, "Hiding image preview area. Timed out waiting for preview to load" - + " within " + mImageLoadTimeoutMillis + "ms."); - collapseParentView(); - if (shouldShowTabs()) { - hideStickyContentPreview(); - } else if (mChooserMultiProfilePagerAdapter.getCurrentRootAdapter() != null) { - mChooserMultiProfilePagerAdapter.getCurrentRootAdapter().hideContentPreview(); + if (!mAtLeastOneLoaded) { + if (mHideParentOnFail) { + Log.i(TAG, "Hiding image preview area. Timed out waiting for preview to load" + + " within " + mImageLoadTimeoutMillis + "ms."); + collapseParentView(); + if (shouldShowTabs()) { + hideStickyContentPreview(); + } else if (mChooserMultiProfilePagerAdapter.getCurrentRootAdapter() != null) { + mChooserMultiProfilePagerAdapter.getCurrentRootAdapter() + .hideContentPreview(); + } + mHideParentOnFail = false; } - mHideParentOnFail = false; + mRemoveSharedElements = true; + startPostponedEnterTransition(); } - mRemoveSharedElements = true; - startPostponedEnterTransition(); } private void collapseParentView() {