From 976cd969839b1a7b8111fadc126df6398524cf28 Mon Sep 17 00:00:00 2001 From: Tony Mak Date: Wed, 8 Apr 2020 14:15:37 +0100 Subject: [PATCH] Fix an issue that setMaxSuggestions(-1) throws unexpectedly As per the javadoc, -1 is a valid input. BUG: 153529167 Test: ag/10976796 Change-Id: I4cf172fbd36b893428be1bb87a9ccb0b7c5c3c6a --- .../android/view/textclassifier/ConversationActions.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/core/java/android/view/textclassifier/ConversationActions.java b/core/java/android/view/textclassifier/ConversationActions.java index 842ba2975b3b5..6ad5cb9135532 100644 --- a/core/java/android/view/textclassifier/ConversationActions.java +++ b/core/java/android/view/textclassifier/ConversationActions.java @@ -27,8 +27,6 @@ import android.os.Parcel; import android.os.Parcelable; import android.text.SpannedString; -import com.android.internal.util.Preconditions; - import java.lang.annotation.Retention; import java.time.ZonedDateTime; import java.time.format.DateTimeFormatter; @@ -491,7 +489,11 @@ public final class ConversationActions implements Parcelable { */ @NonNull public Builder setMaxSuggestions(@IntRange(from = -1) int maxSuggestions) { - mMaxSuggestions = Preconditions.checkArgumentNonnegative(maxSuggestions); + if (maxSuggestions < -1) { + throw new IllegalArgumentException("maxSuggestions has to be greater than or " + + "equal to -1."); + } + mMaxSuggestions = maxSuggestions; return this; }