From 2294f39e2a27758d7b1c698594414096028d34ee Mon Sep 17 00:00:00 2001 From: Alessio Balsini Date: Tue, 26 May 2020 11:11:20 +0100 Subject: [PATCH] SnapshotMergeReported: add retrofit and cow image size Additional information are important to evaluate the impact of Virtual A/B on devices especially related to OTA take rate. Take rate is strictly related to the space that is temporarily allocated in the /data partition (cow_file_size_bytes), as well as knowing if the device has been upgraded to use Virtual A/B (is_vab_retrofit) or if the feature was natively supported. Add these new fields to the SnapshotMergeReported metric. Bug: 154016862 Bug: 157720191 Test: m Signed-off-by: Alessio Balsini Change-Id: Iae8310a8f5364ee94fc8ad6e55362d86cb0752d8 --- cmds/statsd/src/atoms.proto | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/cmds/statsd/src/atoms.proto b/cmds/statsd/src/atoms.proto index c25c3db269f22..c474e71da0231 100644 --- a/cmds/statsd/src/atoms.proto +++ b/cmds/statsd/src/atoms.proto @@ -4860,6 +4860,14 @@ message SnapshotMergeReported { // Number of reboots that occurred after issuing and before completing the // merge of all the snapshot devices. optional int32 intermediate_reboots = 3; + + // The device has been upgraded to Virtual A/B. + optional bool is_vab_retrofit = 4; + + // Space that has been temporarily allocated in the /data partition + // containing the dm-snapshot's copy-on-write data generated during a + // Virtual A/B update. + optional int64 cow_file_size_bytes = 5; } //////////////////////////////////////////////////////////////////////