Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix race condition in UidRecord cleanup" into rvc-d1-dev am: c453c4aff9

Browse Source 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12244064

Change-Id: I7efa28128e6d794cc39a90643f6ead866b5f0f12
This commit is contained in:
Jing Ji
2020-07-28 02:21:32 +00:00
committed by Automerger Merge Worker
parent 0fa3c008a7 c453c4aff9
commit 3febd4a396
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
services/core/java/com/android/server/am/ProcessList.java
View File

@@ -2908,25 +2908,26 @@ public final class ProcessList {
if ((expecting == null) || (old == expecting)) {
mProcessNames.remove(name, uid);
}
if (old != null && old.uidRecord != null) {
old.uidRecord.numProcs--;
old.uidRecord.procRecords.remove(old);
if (old.uidRecord.numProcs == 0) {
final ProcessRecord record = expecting != null ? expecting : old;
if (record != null && record.uidRecord != null) {
final UidRecord uidRecord = record.uidRecord;
uidRecord.numProcs--;
uidRecord.procRecords.remove(record);
if (uidRecord.numProcs == 0) {
// No more processes using this uid, tell clients it is gone.
if (DEBUG_UID_OBSERVERS) Slog.i(TAG_UID_OBSERVERS,
"No more processes in " + old.uidRecord);
mService.enqueueUidChangeLocked(old.uidRecord, -1, UidRecord.CHANGE_GONE);
"No more processes in " + uidRecord);
mService.enqueueUidChangeLocked(uidRecord, -1, UidRecord.CHANGE_GONE);
EventLogTags.writeAmUidStopped(uid);
mActiveUids.remove(uid);
mService.noteUidProcessState(uid, ActivityManager.PROCESS_STATE_NONEXISTENT,
ActivityManager.PROCESS_CAPABILITY_NONE);
}
old.uidRecord = null;
record.uidRecord = null;
}
mIsolatedProcesses.remove(uid);
mGlobalIsolatedUids.freeIsolatedUidLocked(uid);
// Remove the (expected) ProcessRecord from the app zygote
final ProcessRecord record = expecting != null ? expecting : old;
if (record != null && record.appZygote) {
removeProcessFromAppZygoteLocked(record);
}