From 8e7aa79cfa814180412ea7750d244211851db642 Mon Sep 17 00:00:00 2001 From: Jaewan Kim Date: Tue, 28 Jan 2020 11:11:31 +0900 Subject: [PATCH] MediaSessionManager: Apply API review Bug: 138648566 Test: Build Change-Id: I46c0e32ba409736234af0ab50c7bceadaacd2887 --- api/system-current.txt | 4 ++-- .../media/session/MediaSessionManager.java | 19 ++++++++++--------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/api/system-current.txt b/api/system-current.txt index 69319193b535a..cce99e32873f4 100755 --- a/api/system-current.txt +++ b/api/system-current.txt @@ -4373,11 +4373,11 @@ package android.media.session { } public static interface MediaSessionManager.OnMediaKeyEventDispatchedListener { - method public default void onMediaKeyEventDispatched(@NonNull android.view.KeyEvent, @NonNull String, @Nullable android.media.session.MediaSession.Token); + method public void onMediaKeyEventDispatched(@NonNull android.view.KeyEvent, @NonNull String, @Nullable android.media.session.MediaSession.Token); } public static interface MediaSessionManager.OnMediaKeyEventSessionChangedListener { - method public default void onMediaKeyEventSessionChanged(@NonNull String, @Nullable android.media.session.MediaSession.Token); + method public void onMediaKeyEventSessionChanged(@NonNull String, @Nullable android.media.session.MediaSession.Token); } public static interface MediaSessionManager.OnMediaKeyListener { diff --git a/media/java/android/media/session/MediaSessionManager.java b/media/java/android/media/session/MediaSessionManager.java index aece39d78694e..5ef466dfd0e90 100644 --- a/media/java/android/media/session/MediaSessionManager.java +++ b/media/java/android/media/session/MediaSessionManager.java @@ -932,7 +932,7 @@ public final class MediaSessionManager { } /** - * Listener to receive when the media session service + * Listener to be called when the media session service dispatches a media key event. * @hide */ @SystemApi @@ -944,15 +944,15 @@ public final class MediaSessionManager { * is released. * * @param event Dispatched media key event. - * @param packageName Package + * @param packageName The package name * @param sessionToken The media session's token. Can be {@code null}. */ - default void onMediaKeyEventDispatched(@NonNull KeyEvent event, @NonNull String packageName, - @Nullable MediaSession.Token sessionToken) { } + void onMediaKeyEventDispatched(@NonNull KeyEvent event, @NonNull String packageName, + @Nullable MediaSession.Token sessionToken); } /** - * Listener to receive changes in the media key event session, which would receive the media key + * Listener to receive changes in the media key event session, which would receive a media key * event unless specified. * @hide */ @@ -964,13 +964,14 @@ public final class MediaSessionManager { * has specified the target. *

* The session token can be {@link null} if the media button session is unset. In that case, - * framework would dispatch to the last sessions's media button receiver. + * framework would dispatch to the last sessions's media button receiver. If the media + * button receive isn't set as well, then it * * @param packageName The package name who would receive the media key event. Can be empty. - * @param sessionToken The media session's token. Can be {@code null.} + * @param sessionToken The media session's token. Can be {@code null}. */ - default void onMediaKeyEventSessionChanged(@NonNull String packageName, - @Nullable MediaSession.Token sessionToken) { } + void onMediaKeyEventSessionChanged(@NonNull String packageName, + @Nullable MediaSession.Token sessionToken); } /**