From 9697c6c5611e7520d5a11c3a938d778c3035071e Mon Sep 17 00:00:00 2001 From: jiabin Date: Tue, 20 Mar 2018 17:13:04 -0700 Subject: [PATCH] Make back mic available when getting all available mic. Remove the checkType of filtering back mic. Make getAddress() public in AudioDeviceInfo to distinguish different built in mic. Bug: 64038649 Test: run cts Change-Id: I943b7f74f44db7068644f5ffa1b5410cbf567f11 --- api/current.txt | 2 ++ media/java/android/media/AudioDeviceInfo.java | 3 +-- media/java/android/media/AudioManager.java | 3 +-- media/java/android/media/MicrophoneInfo.java | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/api/current.txt b/api/current.txt index 6a9f00e46b07f..09fb7a8be460b 100644 --- a/api/current.txt +++ b/api/current.txt @@ -21926,6 +21926,7 @@ package android.media { } public final class AudioDeviceInfo { + method public java.lang.String getAddress(); method public int[] getChannelCounts(); method public int[] getChannelIndexMasks(); method public int[] getChannelMasks(); @@ -25122,6 +25123,7 @@ package android.media { } public final class MicrophoneInfo { + method public java.lang.String getAddress(); method public java.util.List> getChannelMapping(); method public java.lang.String getDescription(); method public int getDirectionality(); diff --git a/media/java/android/media/AudioDeviceInfo.java b/media/java/android/media/AudioDeviceInfo.java index 86dfc9c887236..ca895fcdfc4a4 100644 --- a/media/java/android/media/AudioDeviceInfo.java +++ b/media/java/android/media/AudioDeviceInfo.java @@ -226,11 +226,10 @@ public final class AudioDeviceInfo { } /** - * @hide * @return The "address" string of the device. This generally contains device-specific * parameters. */ - public String getAddress() { + public @NonNull String getAddress() { return mPort.address(); } diff --git a/media/java/android/media/AudioManager.java b/media/java/android/media/AudioManager.java index 1536bb6880735..a0d168c508be7 100644 --- a/media/java/android/media/AudioManager.java +++ b/media/java/android/media/AudioManager.java @@ -4595,8 +4595,7 @@ public class AudioManager { private static boolean checkTypes(AudioDevicePort port) { return AudioDeviceInfo.convertInternalDeviceToDeviceType(port.type()) != - AudioDeviceInfo.TYPE_UNKNOWN && - port.type() != AudioSystem.DEVICE_IN_BACK_MIC; + AudioDeviceInfo.TYPE_UNKNOWN; } /** diff --git a/media/java/android/media/MicrophoneInfo.java b/media/java/android/media/MicrophoneInfo.java index 004efea64d2d4..d6399a4163fe9 100644 --- a/media/java/android/media/MicrophoneInfo.java +++ b/media/java/android/media/MicrophoneInfo.java @@ -17,6 +17,7 @@ package android.media; import android.annotation.IntDef; +import android.annotation.NonNull; import android.util.Pair; import java.lang.annotation.Retention; @@ -224,12 +225,11 @@ public final class MicrophoneInfo { } /** - * @hide * Returns The "address" string of the microphone that corresponds to the * address returned by {@link AudioDeviceInfo#getAddress()} * @return the address of the microphone */ - public String getAddress() { + public @NonNull String getAddress() { return mAddress; }