From 412bb5ca634eb981774ae23768d7e8c713f7faa5 Mon Sep 17 00:00:00 2001 From: Yigit Boyar Date: Fri, 22 Aug 2014 16:02:40 -0700 Subject: [PATCH] Clear TextView error when text changes This change also fixes another bug where error popup is cleared when cursor moves using dpad, even though the text is not changed. Bug: 15538489 Bug: 3370191 Change-Id: I2804b90178e77ced46477a594331ae1f7306717a --- core/java/android/widget/TextView.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java index a82fa659f9e49..7d3d2ebb42292 100644 --- a/core/java/android/widget/TextView.java +++ b/core/java/android/widget/TextView.java @@ -5712,8 +5712,6 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener } if (mEditor != null && mEditor.mKeyListener != null) { - resetErrorChangedFlag(); - boolean doDown = true; if (otherEvent != null) { try { @@ -7630,6 +7628,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener list.get(i).afterTextChanged(text); } } + hideErrorIfUnchanged(); } void updateAfterEdit() { @@ -7669,7 +7668,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener } ims.mChangedDelta += after-before; } - + resetErrorChangedFlag(); sendOnTextChanged(buffer, start, before, after); onTextChanged(buffer, start, before, after); }