Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Revert "Grant the ACTIVATE_PLATFORM_VPN appop if VPN app has CON...""

Browse Source
This commit is contained in:
Lucas Lin
2022-08-25 05:41:01 +00:00
committed by Gerrit Code Review
parent 649a208492 f2d911662e
commit 3ea732de43
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
services/core/java/com/android/server/connectivity/Vpn.java
View File

@@ -1110,7 +1110,7 @@ public class Vpn {
// Except for Settings and VpnDialogs, the caller should be matched one of oldPackage or // Except for Settings and VpnDialogs, the caller should be matched one of oldPackage or
// newPackage. Otherwise, non VPN owner might get the VPN always-on status of the VPN owner. // newPackage. Otherwise, non VPN owner might get the VPN always-on status of the VPN owner.
// See b/191382886. // See b/191382886.
if (!hasControlVpnPermission()) { if (mContext.checkCallingOrSelfPermission(CONTROL_VPN) != PERMISSION_GRANTED) {
if (oldPackage != null) { if (oldPackage != null) {
verifyCallingUidAndPackage(oldPackage); verifyCallingUidAndPackage(oldPackage);
} }
@@ -2073,10 +2073,6 @@ public class Vpn {
"Unauthorized Caller"); "Unauthorized Caller");
} }
private boolean hasControlVpnPermission() {
return mContext.checkCallingOrSelfPermission(CONTROL_VPN) == PERMISSION_GRANTED;
}
private class Connection implements ServiceConnection { private class Connection implements ServiceConnection {
private IBinder mService; private IBinder mService;
@@ -3901,10 +3897,8 @@ public class Vpn {
Binder.restoreCallingIdentity(token); Binder.restoreCallingIdentity(token);
} }
// If package has CONTROL_VPN, grant the ACTIVATE_PLATFORM_VPN appop. // TODO: if package has CONTROL_VPN, grant the ACTIVATE_PLATFORM_VPN appop.
if (hasControlVpnPermission()) { // This mirrors the prepareAndAuthorize that is used by VpnService.
setPackageAuthorization(packageName, VpnManager.TYPE_VPN_PLATFORM);
}
// Return whether the app is already pre-consented // Return whether the app is already pre-consented
return isVpnProfilePreConsented(mContext, packageName); return isVpnProfilePreConsented(mContext, packageName);