From 3c518a3bd671cf83d067007f6adf7ca9954ed1b5 Mon Sep 17 00:00:00 2001 From: Francois Gaffie Date: Fri, 2 Jul 2021 15:27:41 +0200 Subject: [PATCH] [BUG] AudioService: PlaybackActivityMonitor: fix exploding list This CL fixes the growing list of Playback Monitor client by comparing the cb.asBinder() object to correctly find the previous registration. Test: todo Signed-off-by: Francois Gaffie Change-Id: Ib4ad166f584fe60c2a1e5721f3ab51e9a4151d41 --- .../java/com/android/server/audio/PlaybackActivityMonitor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/audio/PlaybackActivityMonitor.java b/services/core/java/com/android/server/audio/PlaybackActivityMonitor.java index a13b2eb344d93..fa7afe77c33fa 100644 --- a/services/core/java/com/android/server/audio/PlaybackActivityMonitor.java +++ b/services/core/java/com/android/server/audio/PlaybackActivityMonitor.java @@ -779,7 +779,7 @@ public final class PlaybackActivityMonitor // the same time if we still have a public client. while (clientIterator.hasNext()) { PlayMonitorClient pmc = clientIterator.next(); - if (pcdb.equals(pmc.mDispatcherCb)) { + if (pcdb.asBinder().equals(pmc.mDispatcherCb.asBinder())) { pmc.release(); clientIterator.remove(); } else {