From 9b24e5c53a04d764acca4f0f865575f0bec5583a Mon Sep 17 00:00:00 2001 From: Adam Powell Date: Tue, 4 Apr 2017 15:33:23 -0700 Subject: [PATCH] Don't crash when passing null to requestChildFocus Add null checks to ScrollView and HorizontalScrollView for checking the revealOnFocusHint. This should never happen in code called by the framework, but some apps were hitting it. Bug: 36379645 Test: none Change-Id: I220eb88d82126ff08f47a7c2a7fbdddebf07de81 --- core/java/android/widget/HorizontalScrollView.java | 2 +- core/java/android/widget/ScrollView.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/java/android/widget/HorizontalScrollView.java b/core/java/android/widget/HorizontalScrollView.java index da00d9c970b10..0bf246042e006 100644 --- a/core/java/android/widget/HorizontalScrollView.java +++ b/core/java/android/widget/HorizontalScrollView.java @@ -1443,7 +1443,7 @@ public class HorizontalScrollView extends FrameLayout { @Override public void requestChildFocus(View child, View focused) { - if (focused.getRevealOnFocusHint()) { + if (focused != null && focused.getRevealOnFocusHint()) { if (!mIsLayoutDirty) { scrollToChild(focused); } else { diff --git a/core/java/android/widget/ScrollView.java b/core/java/android/widget/ScrollView.java index 0a9e361a20c47..8fc4f5044261f 100644 --- a/core/java/android/widget/ScrollView.java +++ b/core/java/android/widget/ScrollView.java @@ -1468,7 +1468,7 @@ public class ScrollView extends FrameLayout { @Override public void requestChildFocus(View child, View focused) { - if (focused.getRevealOnFocusHint()) { + if (focused != null && focused.getRevealOnFocusHint()) { if (!mIsLayoutDirty) { scrollToChild(focused); } else {