From 3d7e855df3e8556b311ef3900990047554aaa0e5 Mon Sep 17 00:00:00 2001 From: Suchi Amalapurapu Date: Thu, 17 Sep 2009 15:38:20 -0700 Subject: [PATCH] Check if rename of current settings file was successful before persisting new changes to settings. --- services/java/com/android/server/PackageManagerService.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/java/com/android/server/PackageManagerService.java b/services/java/com/android/server/PackageManagerService.java index 45e0ceb55d3e9..323a11ff79a73 100644 --- a/services/java/com/android/server/PackageManagerService.java +++ b/services/java/com/android/server/PackageManagerService.java @@ -6376,7 +6376,10 @@ class PackageManagerService extends IPackageManager.Stub { if (mBackupSettingsFilename.exists()) { mBackupSettingsFilename.delete(); } - mSettingsFilename.renameTo(mBackupSettingsFilename); + if (!mSettingsFilename.renameTo(mBackupSettingsFilename)) { + Log.w(TAG, "Unable to backup package manager settings, current changes will be lost at reboot"); + return; + } } mPastSignatures.clear();