Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Don't pass a null View to OnListItemClickListener. Bug #3365153" into honeycomb

Browse Source
This commit is contained in:
Romain Guy
2011-01-18 20:27:22 -08:00
committed by Android (Google) Code Review
parent f38bddbeb4 7890fe2da4
commit 3cd030a4fe
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/java/android/widget/AbsListView.java
View File

@@ -2439,8 +2439,12 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te
if (adapter != null && mItemCount > 0 && if (adapter != null && mItemCount > 0 &&
motionPosition != INVALID_POSITION && motionPosition != INVALID_POSITION &&
motionPosition < adapter.getCount() && sameWindow()) { motionPosition < adapter.getCount() && sameWindow()) {
performItemClick(getChildAt(motionPosition - mFirstPosition), motionPosition, final View view = getChildAt(motionPosition - mFirstPosition);
adapter.getItemId(motionPosition)); // If there is no view, something bad happened (the view scrolled off the
// screen, etc.) and we should cancel the click
if (view != null) {
performItemClick(view, motionPosition, adapter.getItemId(motionPosition));
}
} }
} }
} }