Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Add a null check for getWindow()"

Browse Source
This commit is contained in:
Treehugger Robot
2019-03-07 17:02:00 +00:00
committed by Gerrit Code Review
parent 04e04516b4 d0de1cd170
commit 3c69948e6a
1 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
core/java/android/preference/DialogPreference.java
View File

@@ -342,16 +342,31 @@ public abstract class DialogPreference extends Preference implements
dialog.show(); dialog.show();
} }
/**
* Get the DecorView.
* @return the DecorView for the current dialog window, if it exists.
* If the window does not exist, null is returned.
*/
private View getDecorView() {
if (mDialog != null && mDialog.getWindow() != null) {
return mDialog.getWindow().getDecorView();
}
return null;
}
void postDismiss() { void postDismiss() {
removeDismissCallbacks(); removeDismissCallbacks();
View decorView = mDialog.getWindow().getDecorView(); View decorView = getDecorView();
if (decorView != null) {
// If decorView is null, dialog was already dismissed
decorView.post(mDismissRunnable); decorView.post(mDismissRunnable);
} }
}
private void removeDismissCallbacks() { private void removeDismissCallbacks() {
if (mDialog != null && mDialog.getWindow() != null View decorView = getDecorView();
&& mDialog.getWindow().getDecorView() != null) { if (decorView != null) {
mDialog.getWindow().getDecorView().removeCallbacks(mDismissRunnable); decorView.removeCallbacks(mDismissRunnable);
} }
} }