diff --git a/packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java b/packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java index 9ccd33226258a..5a35da96375ac 100644 --- a/packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java +++ b/packages/SettingsLib/src/com/android/settingslib/wifi/WifiTracker.java @@ -365,7 +365,7 @@ public class WifiTracker { mConnectivityManager.unregisterNetworkCallback(mNetworkCallback); mRegistered = false; } - unregisterAndClearScoreCache(); + unregisterScoreCache(); pauseScanning(); mContext.getContentResolver().unregisterContentObserver(mObserver); @@ -375,11 +375,14 @@ public class WifiTracker { mStaleScanResults = true; } - private void unregisterAndClearScoreCache() { + private void unregisterScoreCache() { mNetworkScoreManager.unregisterNetworkScoreCache(NetworkKey.TYPE_WIFI, mScoreCache); - mScoreCache.clearScores(); - // Synchronize on mLock to avoid concurrent modification during updateAccessPoints + // We do not want to clear the existing scores in the cache, as this method is called during + // stop tracking on activity pause. Hence, on resumption we want the ability to show the + // last known, potentially stale, scores. However, by clearing requested scores, the scores + // will be requested again upon resumption of tracking, and if any changes have occurred + // the listeners (UI) will be updated accordingly. synchronized (mLock) { mRequestedScores.clear(); } diff --git a/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java b/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java index b6d0c457db7c7..c87d01a7da8e3 100644 --- a/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java +++ b/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java @@ -472,6 +472,17 @@ public class WifiTrackerTest { assertTrue(mRequestedKeys.contains(NETWORK_KEY_2)); } + @Test + public void stopTracking_shouldNotClearExistingScores() + throws InterruptedException { + // Start the tracker and inject the initial scan results and then stop tracking + WifiTracker tracker = createTrackerWithImmediateBroadcastsAndInjectInitialScanResults(); + updateScoresAndWaitForAccessPointsChangedCallback(tracker); + tracker.stopTracking(); + + assertThat(mScoreCacheCaptor.getValue().getScoredNetwork(NETWORK_KEY_1)).isNotNull(); + } + @Test public void scoreCacheUpdateScoresShouldTriggerOnAccessPointsChanged() throws InterruptedException {