From 3a76fd627945c1df59aa0318867401e0e53da022 Mon Sep 17 00:00:00 2001 From: Mike Lockwood Date: Tue, 1 Sep 2009 07:26:56 -0400 Subject: [PATCH] LocationManagerService: Add null pointer check and remove useless finalize() method. Change-Id: I4017d38a1bea7564a85575486a7c2aef569dfe5d Signed-off-by: Mike Lockwood --- .../com/android/server/LocationManagerService.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/services/java/com/android/server/LocationManagerService.java b/services/java/com/android/server/LocationManagerService.java index 7c33e3736c4a6..dfab17e8fa6d3 100644 --- a/services/java/com/android/server/LocationManagerService.java +++ b/services/java/com/android/server/LocationManagerService.java @@ -854,7 +854,9 @@ public class LocationManagerService extends ILocationManager.Stub implements Run */ void disposeLocked() { ArrayList records = mRecordsByProvider.get(this.mProvider); - records.remove(this); + if (records != null) { + records.remove(this); + } } @Override @@ -873,15 +875,6 @@ public class LocationManagerService extends ILocationManager.Stub implements Run mLastFixBroadcast.dump(new PrintWriterPrinter(pw), prefix + " "); pw.println(prefix + "mLastStatusBroadcast=" + mLastStatusBroadcast); } - - /** - * Calls dispose(). - */ - @Override protected void finalize() { - synchronized (mLock) { - disposeLocked(); - } - } } private Receiver getReceiver(ILocationListener listener) {