Merge "Only check downstream permissions in preflight in RecognitionService" into sc-dev

This commit is contained in:
TreeHugger Robot
2021-07-15 17:44:56 +00:00
committed by Android (Google) Code Review

View File

@@ -115,18 +115,14 @@ public abstract class RecognitionService extends Service {
@NonNull AttributionSource attributionSource) { @NonNull AttributionSource attributionSource) {
try { try {
if (mCurrentCallback == null) { if (mCurrentCallback == null) {
Context attributionContext = createContext(new ContextParams.Builder()
.setNextAttributionSource(attributionSource)
.build());
boolean preflightPermissionCheckPassed = checkPermissionForPreflight( boolean preflightPermissionCheckPassed = checkPermissionForPreflight(
attributionContext.getAttributionSource()); attributionSource);
if (preflightPermissionCheckPassed) { if (preflightPermissionCheckPassed) {
if (DBG) { if (DBG) {
Log.d(TAG, "created new mCurrentCallback, listener = " Log.d(TAG, "created new mCurrentCallback, listener = "
+ listener.asBinder()); + listener.asBinder());
} }
mCurrentCallback = new Callback(listener, attributionSource, mCurrentCallback = new Callback(listener, attributionSource);
attributionContext);
RecognitionService.this.onStartListening(intent, mCurrentCallback); RecognitionService.this.onStartListening(intent, mCurrentCallback);
} }
@@ -293,15 +289,8 @@ public abstract class RecognitionService extends Service {
private Callback(IRecognitionListener listener, private Callback(IRecognitionListener listener,
@NonNull AttributionSource attributionSource) { @NonNull AttributionSource attributionSource) {
this(listener, attributionSource, null);
}
private Callback(IRecognitionListener listener,
@NonNull AttributionSource attributionSource,
@Nullable Context attributionContext) {
mListener = listener; mListener = listener;
mCallingAttributionSource = attributionSource; mCallingAttributionSource = attributionSource;
mAttributionContext = attributionContext;
} }
/** /**