From 77e88f613bac3f96c4370aecb7a85e2018c9e125 Mon Sep 17 00:00:00 2001 From: Michal Brzezinski Date: Fri, 17 Feb 2023 15:31:24 +0000 Subject: [PATCH] Log when qs height is set to 0 but probably shouldn't These logs will be deleted in ~2 months, they're temporary to help debug when b/219589379 happens again Bug: 219589379 Bug: 269742565 Test: just adding logs Change-Id: I8c6b384fe35ed4cde1e9d381edab96f09c36f203 --- .../systemui/shade/QuickSettingsController.java | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java b/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java index c0ef4c1a872ae..319c22f804d59 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java +++ b/packages/SystemUI/src/com/android/systemui/shade/QuickSettingsController.java @@ -194,7 +194,12 @@ public class QuickSettingsController { private boolean mAnimatingHiddenFromCollapsed; private boolean mVisible; private float mExpansionHeight; + /** + * QS height when QS expansion fraction is 0 so when QS is collapsed. That state doesn't really + * exist for split shade so currently this value is always 0 then. + */ private int mMinExpansionHeight; + /** QS height when QS expansion fraction is 1 so qs is fully expanded */ private int mMaxExpansionHeight; /** Expansion fraction of the notification shade */ private float mShadeExpandedFraction; @@ -693,6 +698,7 @@ public class QuickSettingsController { /** update Qs height state */ public void setExpansionHeight(float height) { + checkCorrectSplitShadeState(height); int maxHeight = getMaxExpansionHeight(); height = Math.min(Math.max( height, getMinExpansionHeight()), maxHeight); @@ -714,6 +720,14 @@ public class QuickSettingsController { } } + /** TODO(b/269742565) Remove this logging */ + private void checkCorrectSplitShadeState(float height) { + if (mSplitShadeEnabled && height == 0 + && mPanelViewControllerLazy.get().isShadeFullyOpen()) { + Log.wtfStack(TAG, "qsExpansion set to 0 while split shade is expanding or open"); + } + } + /** */ public void setHeightOverrideToDesiredHeight() { if (isSizeChangeAnimationRunning() && isQsFragmentCreated()) {