From 3afd8b0d1ad191b4559910e699490883e50e1688 Mon Sep 17 00:00:00 2001 From: Alan Viverette Date: Thu, 26 Feb 2015 13:36:28 -0800 Subject: [PATCH] Vertically center seek bar track and thumb when maxHeight is set Also removes unused tinting method from ProgressBar. Bug: 19480491 Change-Id: I9faeff51870088c2b5ba7386dfbfd7c4898c5564 --- core/java/android/widget/AbsSeekBar.java | 13 ++++++++----- core/java/android/widget/ProgressBar.java | 18 ------------------ 2 files changed, 8 insertions(+), 23 deletions(-) diff --git a/core/java/android/widget/AbsSeekBar.java b/core/java/android/widget/AbsSeekBar.java index 79ad6e37c1091..1892184a33929 100644 --- a/core/java/android/widget/AbsSeekBar.java +++ b/core/java/android/widget/AbsSeekBar.java @@ -403,23 +403,26 @@ public abstract class AbsSeekBar extends ProgressBar { } private void updateThumbAndTrackPos(int w, int h) { + final int paddedHeight = h - mPaddingTop - mPaddingBottom; final Drawable track = getCurrentDrawable(); final Drawable thumb = mThumb; // The max height does not incorporate padding, whereas the height // parameter does. - final int trackHeight = Math.min(mMaxHeight, h - mPaddingTop - mPaddingBottom); + final int trackHeight = Math.min(mMaxHeight, paddedHeight); final int thumbHeight = thumb == null ? 0 : thumb.getIntrinsicHeight(); // Apply offset to whichever item is taller. final int trackOffset; final int thumbOffset; if (thumbHeight > trackHeight) { - trackOffset = (thumbHeight - trackHeight) / 2; - thumbOffset = 0; + final int offsetHeight = (paddedHeight - thumbHeight) / 2; + trackOffset = offsetHeight + (thumbHeight - trackHeight) / 2; + thumbOffset = offsetHeight + 0; } else { - trackOffset = 0; - thumbOffset = (trackHeight - thumbHeight) / 2; + final int offsetHeight = (paddedHeight - trackHeight) / 2; + trackOffset = offsetHeight + 0; + thumbOffset = offsetHeight + (trackHeight - thumbHeight) / 2; } if (track != null) { diff --git a/core/java/android/widget/ProgressBar.java b/core/java/android/widget/ProgressBar.java index 03878fc40c3e8..9f98965f051ba 100644 --- a/core/java/android/widget/ProgressBar.java +++ b/core/java/android/widget/ProgressBar.java @@ -1235,24 +1235,6 @@ public class ProgressBar extends View { } } - private void setDrawableTint(int id, ColorStateList tint, Mode tintMode, boolean fallback) { - Drawable layer = null; - - // We expect a layer drawable, so try to find the target ID. - final Drawable d = mCurrentDrawable; - if (d instanceof LayerDrawable) { - layer = ((LayerDrawable) d).findDrawableByLayerId(id); - } - - if (fallback && layer == null) { - layer = d; - } - - layer.mutate(); - layer.setTintList(tint); - layer.setTintMode(tintMode); - } - private synchronized void doRefreshProgress(int id, int progress, boolean fromUser, boolean callBackToApp) { float scale = mMax > 0 ? (float) progress / (float) mMax : 0;