From 0c4de34deffa78a9ad9270effeaf1efd28398d69 Mon Sep 17 00:00:00 2001
From: Ale Nijamkin <nijamkin@google.com>
Date: Thu, 20 Apr 2023 22:00:09 +0000
Subject: [PATCH] Makes lock screen long-press popup background fixed.

By design, the icon, text, and background colors should not be changed between light and dark theme. The current code only uses a fixed color for the icon and text but uses a theme-changing color for the background. In light theme, this means that the popup is displayed as dark icon and text over a dark background, manifesting as the attached bug.

Change-Id: Iba53a5742fd209bd8abbaf14eb57f2d9600f9b2c
Fix: 279068244
Test: manually verified that the bug no longer manifest in either light or dark theme, restarting System UI each time the system theme was switched. It's now always dark icon/text over light background, as per UX design.
---
 .../res/drawable/keyguard_settings_popup_menu_background.xml    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml b/packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml
index a0ceb81d42f44..fe76ba7e5b8c5 100644
--- a/packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml
+++ b/packages/SystemUI/res/drawable/keyguard_settings_popup_menu_background.xml
@@ -26,7 +26,7 @@
     </item>
     <item>
         <shape android:shape="rectangle">
-            <solid android:color="?androidprv:attr/materialColorOnBackground" />
+            <solid android:color="?androidprv:attr/materialColorSecondaryFixed" />
             <corners android:radius="@dimen/keyguard_affordance_fixed_radius" />
         </shape>
     </item>