From 9dfbcad849911271a1ad03e5510778f952263b82 Mon Sep 17 00:00:00 2001 From: JW Wang Date: Mon, 10 Jan 2022 16:19:09 +0800 Subject: [PATCH] Support runtime log toggling (1/n) * Add support for runtime log toggling * Add logs to debug session addition/removal Bug: 213808335 Test: m Change-Id: I5b43eb7d201670f175d5f07a7b99ee2f5d0bc830 --- .../com/android/server/pm/PackageInstallerService.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/pm/PackageInstallerService.java b/services/core/java/com/android/server/pm/PackageInstallerService.java index cfcf199d01a49..3a5e2226ec8b7 100644 --- a/services/core/java/com/android/server/pm/PackageInstallerService.java +++ b/services/core/java/com/android/server/pm/PackageInstallerService.java @@ -70,6 +70,7 @@ import android.text.format.DateUtils; import android.util.ArraySet; import android.util.AtomicFile; import android.util.ExceptionUtils; +import android.util.Log; import android.util.Slog; import android.util.SparseArray; import android.util.SparseBooleanArray; @@ -121,7 +122,7 @@ import java.util.function.Supplier; public class PackageInstallerService extends IPackageInstaller.Stub implements PackageSessionProvider { private static final String TAG = "PackageInstaller"; - private static final boolean LOGD = false; + private static final boolean LOGD = Log.isLoggable(TAG, Log.DEBUG); private static final boolean DEBUG = Build.IS_DEBUGGABLE; @@ -510,6 +511,7 @@ public class PackageInstallerService extends IPackageInstaller.Stub implements valid = true; } if (!valid) { + Slog.w(TAG, "Remove old session: " + session.sessionId); // Remove expired sessions as well as child sessions if any mSessions.remove(session.sessionId); // Since this is early during boot we don't send @@ -850,6 +852,9 @@ public class PackageInstallerService extends IPackageInstaller.Stub implements mCallbacks.notifySessionCreated(session.sessionId, session.userId); mSettingsWriteRequest.schedule(); + if (LOGD) { + Slog.d(TAG, "Created session id=" + sessionId + " staged=" + params.isStaged); + } return sessionId; }