From 7bce9031083c0204972223c95c354910a15ef5ce Mon Sep 17 00:00:00 2001 From: lifr Date: Tue, 25 Feb 2020 21:11:25 +0800 Subject: [PATCH] Define rcode=12~15 (UNASSIGNED) in rcode enum type RCODE Name 11 NS_R_MAX 12 NS_R_UNASSIGNED12 13 NS_R_UNASSIGNED13 14 NS_R_UNASSIGNED14 15 NS_R_UNASSIGNED15 16 NS_R_BADVERS According the stats data of Dns Resolver module, Some DNS Servers might return undefined code to devices. Without the enum definition, that would be noise for our dashboard Bug: 150194702 Test: Manual test with statsd_testdrive Change-Id: I178164f37b70d0ce86dfb7e37e01b663abbf82f2 --- core/proto/android/stats/dnsresolver/dns_resolver.proto | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/core/proto/android/stats/dnsresolver/dns_resolver.proto b/core/proto/android/stats/dnsresolver/dns_resolver.proto index afd109996722a..9749e82a7a3f5 100644 --- a/core/proto/android/stats/dnsresolver/dns_resolver.proto +++ b/core/proto/android/stats/dnsresolver/dns_resolver.proto @@ -62,6 +62,13 @@ enum NsRcode { NS_R_NOTAUTH = 9; // Not authoritative for zone NS_R_NOTZONE = 10; // Zone of record different from zone section NS_R_MAX = 11; + // Define rcode=12~15(UNASSIGNED) in rcode enum type. + // Some DNS Servers might return undefined code to devices. + // Without the enum definition, that would be noise for our dashboard. + NS_R_UNASSIGNED12 = 12; // Unassigned + NS_R_UNASSIGNED13 = 13; // Unassigned + NS_R_UNASSIGNED14 = 14; // Unassigned + NS_R_UNASSIGNED15 = 15; // Unassigned // The following are EDNS extended rcodes NS_R_BADVERS = 16; // The following are TSIG errors