From f9439ab4072c71b294167524fdddb5cbe39a5923 Mon Sep 17 00:00:00 2001 From: Mady Mellor Date: Thu, 30 Jan 2020 16:06:53 -0800 Subject: [PATCH] Fix experimental bubbles from HUN'ing when they shouldn't I changed this to onNotificationAdded so that we could extract the avatar generated for the messaging template for experimental bubbles, however, that breaks how notification interruption state provider (NISP) works (we get onNotificationAdded after it goes through NISP that to check if the notif should HUN). It's technically more correct to use onPendingEntryAdded here, so lets do that. If the person object doesn't have an avatar we'll end up using the small or large icon from the notification instead, this at least works for most apps I've tried with experimental bubbles. Test: have no hangouts bubbles, get a hangouts bubble, note that it doesn't HUN Fixes: 148609860 Change-Id: I6e19e49b8b5f13969c30410450826bf480fb9d34 --- .../src/com/android/systemui/bubbles/BubbleController.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/bubbles/BubbleController.java b/packages/SystemUI/src/com/android/systemui/bubbles/BubbleController.java index e954163d51aae..a26cce0bfc0c4 100644 --- a/packages/SystemUI/src/com/android/systemui/bubbles/BubbleController.java +++ b/packages/SystemUI/src/com/android/systemui/bubbles/BubbleController.java @@ -414,7 +414,7 @@ public class BubbleController implements ConfigurationController.ConfigurationLi mNotificationEntryManager.addNotificationEntryListener( new NotificationEntryListener() { @Override - public void onNotificationAdded(NotificationEntry entry) { + public void onPendingEntryAdded(NotificationEntry entry) { onEntryAdded(entry); }