From 008e1fb9ed9ab18726762839bcfc74cb0feb82c8 Mon Sep 17 00:00:00 2001 From: Deepanshu Gupta Date: Tue, 7 Jul 2015 12:24:47 -0700 Subject: [PATCH 1/2] Update intellij project for tools-common sources. Use the sources.jar for tools-common instead of the environment variable. Change-Id: Ia1a3e8c32f66610e761bacce08c7eb5915e7ed0f --- tools/layoutlib/bridge/bridge.iml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/layoutlib/bridge/bridge.iml b/tools/layoutlib/bridge/bridge.iml index af2fe7fc0a301..ccc10b325b776 100644 --- a/tools/layoutlib/bridge/bridge.iml +++ b/tools/layoutlib/bridge/bridge.iml @@ -46,7 +46,7 @@ - + From c71450114131c59bb3a8d65968faae4995cd2345 Mon Sep 17 00:00:00 2001 From: Deepanshu Gupta Date: Tue, 7 Jul 2015 13:10:14 -0700 Subject: [PATCH 2/2] Revert "Replace infinite loop with foreach." This reverts commit c77f9c76e4142db8dd76a28ad99b8f0395b82eba. Class.getDeclaredClasses() doesn't return anonymous inner class and hence the change was wrong. The revert doesn't undo the typo fixed in the original change. Change-Id: Id0595c4bc3db1185dd1ce39808a6b8c3610a1e11 --- .../android/tools/layoutlib/create/AsmGenerator.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/layoutlib/create/src/com/android/tools/layoutlib/create/AsmGenerator.java b/tools/layoutlib/create/src/com/android/tools/layoutlib/create/AsmGenerator.java index dae5509f2aa3c..f6c2626e42713 100644 --- a/tools/layoutlib/create/src/com/android/tools/layoutlib/create/AsmGenerator.java +++ b/tools/layoutlib/create/src/com/android/tools/layoutlib/create/AsmGenerator.java @@ -94,8 +94,14 @@ public class AsmGenerator { ListIterator> iter = injectedClasses.listIterator(); while (iter.hasNext()) { Class clazz = iter.next(); - for (Class aClass : clazz.getDeclaredClasses()) { - iter.add(aClass); + try { + int i = 1; + while(i < 100) { + iter.add(Class.forName(clazz.getName() + "$" + i)); + i++; + } + } catch (ClassNotFoundException ignored) { + // Expected. } } mInjectClasses = injectedClasses.toArray(new Class[0]);