From 373e13d9c8e95c9a40d21332873baed4a2ff30a9 Mon Sep 17 00:00:00 2001 From: yyalan Date: Thu, 28 Apr 2022 11:19:57 +0100 Subject: [PATCH] Fix jumping slider in split shade In BrightnessMirrorController constructor, setup the slider mirror's paddings from resources so that it is align to the slider's position. We need to call updateResources() in the constructor to setup the mBrightnessMirrorBackgroundPadding to be used by setLocationAndSize(). Fixes: 230478558 Test: android.platform.test.scenario.sysui.quicksettings.SwipeBrightness Change-Id: If0ca3acc2df031f61613446797021a2cb33cabf2 --- packages/SystemUI/res/layout/brightness_mirror_container.xml | 1 - .../systemui/statusbar/policy/BrightnessMirrorController.java | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/SystemUI/res/layout/brightness_mirror_container.xml b/packages/SystemUI/res/layout/brightness_mirror_container.xml index ac90db3e5e199..1bf45aad89060 100644 --- a/packages/SystemUI/res/layout/brightness_mirror_container.xml +++ b/packages/SystemUI/res/layout/brightness_mirror_container.xml @@ -23,7 +23,6 @@ android:background="@drawable/brightness_mirror_background" android:layout_gravity="center_vertical" android:layout_margin="8dp" - android:padding="@dimen/rounded_slider_background_padding" android:gravity="center" android:visibility="invisible"> diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/policy/BrightnessMirrorController.java b/packages/SystemUI/src/com/android/systemui/statusbar/policy/BrightnessMirrorController.java index 5bd20ff2d090a..a29ba916eb41d 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/policy/BrightnessMirrorController.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/policy/BrightnessMirrorController.java @@ -68,6 +68,7 @@ public class BrightnessMirrorController mBrightnessMirror.setVisibility(View.INVISIBLE); }); mVisibilityCallback = visibilityCallback; + updateResources(); } public void showMirror() {