Update redaction upon profile changes
We can't rely on status bar state changes to update the notification list. The current user might not be set yet, causing wrong notifications to become visible. Fixes: 145135488 Test: manual Test: atest NotificationStackScrollLayoutTest Change-Id: I34d1d5f9a751c1d7680a5a5941c39b9fe33a473b Merged-In: I34d1d5f9a751c1d7680a5a5941c39b9fe33a473b
This commit is contained in:
@@ -566,6 +566,8 @@ public class NotificationStackScrollLayout extends ViewGroup implements ScrollAd
|
|||||||
mRoundnessManager.setAnimatedChildren(mChildrenToAddAnimated);
|
mRoundnessManager.setAnimatedChildren(mChildrenToAddAnimated);
|
||||||
mRoundnessManager.setOnRoundingChangedCallback(this::invalidate);
|
mRoundnessManager.setOnRoundingChangedCallback(this::invalidate);
|
||||||
addOnExpandedHeightChangedListener(mRoundnessManager::setExpanded);
|
addOnExpandedHeightChangedListener(mRoundnessManager::setExpanded);
|
||||||
|
mLockscreenUserManager.addUserChangedListener(userId ->
|
||||||
|
updateSensitiveness(false /* animated */));
|
||||||
setOutlineProvider(mOutlineProvider);
|
setOutlineProvider(mOutlineProvider);
|
||||||
|
|
||||||
// Blocking helper manager wants to know the expanded state, update as well.
|
// Blocking helper manager wants to know the expanded state, update as well.
|
||||||
@@ -4602,7 +4604,8 @@ public class NotificationStackScrollLayout extends ViewGroup implements ScrollAd
|
|||||||
}
|
}
|
||||||
|
|
||||||
@ShadeViewRefactor(RefactorComponent.SHADE_VIEW)
|
@ShadeViewRefactor(RefactorComponent.SHADE_VIEW)
|
||||||
private void setHideSensitive(boolean hideSensitive, boolean animate) {
|
private void updateSensitiveness(boolean animate) {
|
||||||
|
boolean hideSensitive = mLockscreenUserManager.isAnyProfilePublicMode();
|
||||||
if (hideSensitive != mAmbientState.isHideSensitive()) {
|
if (hideSensitive != mAmbientState.isHideSensitive()) {
|
||||||
int childCount = getChildCount();
|
int childCount = getChildCount();
|
||||||
for (int i = 0; i < childCount; i++) {
|
for (int i = 0; i < childCount; i++) {
|
||||||
@@ -5306,7 +5309,7 @@ public class NotificationStackScrollLayout extends ViewGroup implements ScrollAd
|
|||||||
|
|
||||||
SysuiStatusBarStateController state = (SysuiStatusBarStateController)
|
SysuiStatusBarStateController state = (SysuiStatusBarStateController)
|
||||||
Dependency.get(StatusBarStateController.class);
|
Dependency.get(StatusBarStateController.class);
|
||||||
setHideSensitive(publicMode, state.goingToFullShade() /* animate */);
|
updateSensitiveness(state.goingToFullShade() /* animate */);
|
||||||
setDimmed(onKeyguard, state.fromShadeLocked() /* animate */);
|
setDimmed(onKeyguard, state.fromShadeLocked() /* animate */);
|
||||||
setExpandingEnabled(!onKeyguard);
|
setExpandingEnabled(!onKeyguard);
|
||||||
ActivatableNotificationView activatedChild = getActivatedChild();
|
ActivatableNotificationView activatedChild = getActivatedChild();
|
||||||
|
|||||||
@@ -57,6 +57,8 @@ import com.android.systemui.classifier.FalsingManagerFake;
|
|||||||
import com.android.systemui.plugins.statusbar.NotificationMenuRowPlugin;
|
import com.android.systemui.plugins.statusbar.NotificationMenuRowPlugin;
|
||||||
import com.android.systemui.plugins.statusbar.StatusBarStateController;
|
import com.android.systemui.plugins.statusbar.StatusBarStateController;
|
||||||
import com.android.systemui.statusbar.EmptyShadeView;
|
import com.android.systemui.statusbar.EmptyShadeView;
|
||||||
|
import com.android.systemui.statusbar.NotificationLockscreenUserManager;
|
||||||
|
import com.android.systemui.statusbar.NotificationLockscreenUserManager.UserChangedListener;
|
||||||
import com.android.systemui.statusbar.NotificationPresenter;
|
import com.android.systemui.statusbar.NotificationPresenter;
|
||||||
import com.android.systemui.statusbar.NotificationRemoteInputManager;
|
import com.android.systemui.statusbar.NotificationRemoteInputManager;
|
||||||
import com.android.systemui.statusbar.NotificationShelf;
|
import com.android.systemui.statusbar.NotificationShelf;
|
||||||
@@ -119,6 +121,8 @@ public class NotificationStackScrollLayoutTest extends SysuiTestCase {
|
|||||||
@Mock private MetricsLogger mMetricsLogger;
|
@Mock private MetricsLogger mMetricsLogger;
|
||||||
@Mock private NotificationRoundnessManager mNotificationRoundnessManager;
|
@Mock private NotificationRoundnessManager mNotificationRoundnessManager;
|
||||||
@Mock private KeyguardBypassController mKeyguardBypassController;
|
@Mock private KeyguardBypassController mKeyguardBypassController;
|
||||||
|
@Mock private NotificationLockscreenUserManager mLockscreenUserManager;
|
||||||
|
private UserChangedListener mUserChangedListener;
|
||||||
private TestableNotificationEntryManager mEntryManager;
|
private TestableNotificationEntryManager mEntryManager;
|
||||||
private int mOriginalInterruptionModelSetting;
|
private int mOriginalInterruptionModelSetting;
|
||||||
|
|
||||||
@@ -138,6 +142,8 @@ public class NotificationStackScrollLayoutTest extends SysuiTestCase {
|
|||||||
NotificationBlockingHelperManager.class,
|
NotificationBlockingHelperManager.class,
|
||||||
mBlockingHelperManager);
|
mBlockingHelperManager);
|
||||||
mDependency.injectTestDependency(SysuiStatusBarStateController.class, mBarState);
|
mDependency.injectTestDependency(SysuiStatusBarStateController.class, mBarState);
|
||||||
|
mDependency.injectTestDependency(NotificationLockscreenUserManager.class,
|
||||||
|
mLockscreenUserManager);
|
||||||
mDependency.injectTestDependency(MetricsLogger.class, mMetricsLogger);
|
mDependency.injectTestDependency(MetricsLogger.class, mMetricsLogger);
|
||||||
mDependency.injectTestDependency(NotificationRemoteInputManager.class,
|
mDependency.injectTestDependency(NotificationRemoteInputManager.class,
|
||||||
mRemoteInputManager);
|
mRemoteInputManager);
|
||||||
@@ -152,6 +158,8 @@ public class NotificationStackScrollLayoutTest extends SysuiTestCase {
|
|||||||
|
|
||||||
|
|
||||||
NotificationShelf notificationShelf = mock(NotificationShelf.class);
|
NotificationShelf notificationShelf = mock(NotificationShelf.class);
|
||||||
|
ArgumentCaptor<UserChangedListener> userChangedCaptor = ArgumentCaptor
|
||||||
|
.forClass(UserChangedListener.class);
|
||||||
|
|
||||||
// The actual class under test. You may need to work with this class directly when
|
// The actual class under test. You may need to work with this class directly when
|
||||||
// testing anonymous class members of mStackScroller, like mMenuEventListener,
|
// testing anonymous class members of mStackScroller, like mMenuEventListener,
|
||||||
@@ -174,6 +182,8 @@ public class NotificationStackScrollLayoutTest extends SysuiTestCase {
|
|||||||
mStackScroller.setGroupManager(mGroupManager);
|
mStackScroller.setGroupManager(mGroupManager);
|
||||||
mStackScroller.setEmptyShadeView(mEmptyShadeView);
|
mStackScroller.setEmptyShadeView(mEmptyShadeView);
|
||||||
mStackScroller.setIconAreaController(mNotificationIconAreaController);
|
mStackScroller.setIconAreaController(mNotificationIconAreaController);
|
||||||
|
verify(mLockscreenUserManager).addUserChangedListener(userChangedCaptor.capture());
|
||||||
|
mUserChangedListener = userChangedCaptor.getValue();
|
||||||
|
|
||||||
// Stub out functionality that isn't necessary to test.
|
// Stub out functionality that isn't necessary to test.
|
||||||
doNothing().when(mBar)
|
doNothing().when(mBar)
|
||||||
@@ -246,6 +256,12 @@ public class NotificationStackScrollLayoutTest extends SysuiTestCase {
|
|||||||
verify(mBlockingHelperManager).setNotificationShadeExpanded(100f);
|
verify(mBlockingHelperManager).setNotificationShadeExpanded(100f);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testOnStatePostChange_verifyIfProfileIsPublic() {
|
||||||
|
mUserChangedListener.onUserChanged(0);
|
||||||
|
verify(mLockscreenUserManager).isAnyProfilePublicMode();
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void manageNotifications_visible() {
|
public void manageNotifications_visible() {
|
||||||
FooterView view = mock(FooterView.class);
|
FooterView view = mock(FooterView.class);
|
||||||
|
|||||||
Reference in New Issue
Block a user