From 37293308b4e8c954bc423fb2f2c677fb56397402 Mon Sep 17 00:00:00 2001 From: Ruoyao Liu Date: Mon, 21 Jan 2019 11:36:18 +0800 Subject: [PATCH] Enable more logs for networking Sometimes we would encounter problems that happen by chance and hard to reproduce. So we recommend to enable more logs in ENG and UESRDEBUG load by default. Bug: 123256412 Test: android.net.ip.IpClientTest can pass Change-Id: Ia3363de96966a4e86ab550c768fb70317da005ed --- packages/NetworkStack/src/android/net/dhcp/DhcpClient.java | 6 +++--- .../src/android/net/ip/IpReachabilityMonitor.java | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/NetworkStack/src/android/net/dhcp/DhcpClient.java b/packages/NetworkStack/src/android/net/dhcp/DhcpClient.java index 0b7809e9f614f..c6dd0117477b6 100644 --- a/packages/NetworkStack/src/android/net/dhcp/DhcpClient.java +++ b/packages/NetworkStack/src/android/net/dhcp/DhcpClient.java @@ -102,9 +102,9 @@ public class DhcpClient extends StateMachine { private static final String TAG = "DhcpClient"; private static final boolean DBG = true; - private static final boolean STATE_DBG = false; - private static final boolean MSG_DBG = false; - private static final boolean PACKET_DBG = false; + private static final boolean STATE_DBG = Log.isLoggable(TAG, Log.DEBUG); + private static final boolean MSG_DBG = Log.isLoggable(TAG, Log.DEBUG); + private static final boolean PACKET_DBG = Log.isLoggable(TAG, Log.DEBUG); // Metrics events: must be kept in sync with server-side aggregation code. /** Represents transitions from DhcpInitState to DhcpBoundState */ diff --git a/packages/NetworkStack/src/android/net/ip/IpReachabilityMonitor.java b/packages/NetworkStack/src/android/net/ip/IpReachabilityMonitor.java index 3aa6933fe8f2d..c19a24eb7fb67 100644 --- a/packages/NetworkStack/src/android/net/ip/IpReachabilityMonitor.java +++ b/packages/NetworkStack/src/android/net/ip/IpReachabilityMonitor.java @@ -129,8 +129,8 @@ import java.util.Map; */ public class IpReachabilityMonitor { private static final String TAG = "IpReachabilityMonitor"; - private static final boolean DBG = false; - private static final boolean VDBG = false; + private static final boolean DBG = Log.isLoggable(TAG, Log.DEBUG); + private static final boolean VDBG = Log.isLoggable(TAG, Log.VERBOSE); public interface Callback { // This callback function must execute as quickly as possible as it is