From 250f6a7425fbd61fbdd5321ac56a7ceee928bf15 Mon Sep 17 00:00:00 2001 From: Robert Shih Date: Fri, 26 Feb 2021 08:20:31 -0800 Subject: [PATCH] MediaDrm: detailed Exception messages continued Exception types covered: * UnsupportedSchemeException * MediaDrmResetException Bug: 162255728 Test: MediaDrmTest#testGetLogMessages Change-Id: I4880035d3d8db5835b979cd6da064fe813d1f6b4 --- media/jni/android_media_MediaDrm.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/media/jni/android_media_MediaDrm.cpp b/media/jni/android_media_MediaDrm.cpp index 56f6c45bb50ee..53f6fe24556b6 100644 --- a/media/jni/android_media_MediaDrm.cpp +++ b/media/jni/android_media_MediaDrm.cpp @@ -445,8 +445,7 @@ static bool throwExceptionAsNecessary( jniThrowException(env, "android/media/DeniedByServerException", msg); return true; } else if (err == DEAD_OBJECT) { - jniThrowException(env, "android/media/MediaDrmResetException", - "mediaserver died"); + jniThrowException(env, "android/media/MediaDrmResetException", msg); return true; } else if (isSessionException(err)) { throwSessionException(env, msg, err); @@ -967,10 +966,12 @@ static void android_media_MediaDrm_native_setup( status_t err = drm->initCheck(); if (err != OK) { + auto logs(DrmUtils::gLogBuf.getLogs()); + auto msg(DrmUtils::GetExceptionMessage(err, "Failed to instantiate drm object", logs)); jniThrowException( env, "android/media/UnsupportedSchemeException", - "Failed to instantiate drm object."); + msg.c_str()); return; }