From f8cb525497441600796d8a9cfcea0fb7908503cc Mon Sep 17 00:00:00 2001 From: Greg Daniel Date: Wed, 30 Jun 2021 10:40:34 -0400 Subject: [PATCH] Make sure we check for valid GrContext when pinning images. Test: manual building and running. Bug: 187540936 Change-Id: Ie900d80128646c8ca2d4fce41d436019e3cf9c71 --- libs/hwui/pipeline/skia/SkiaPipeline.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libs/hwui/pipeline/skia/SkiaPipeline.cpp b/libs/hwui/pipeline/skia/SkiaPipeline.cpp index 5462623e75ff3..44a6e43546081 100644 --- a/libs/hwui/pipeline/skia/SkiaPipeline.cpp +++ b/libs/hwui/pipeline/skia/SkiaPipeline.cpp @@ -59,6 +59,10 @@ void SkiaPipeline::onDestroyHardwareResources() { } bool SkiaPipeline::pinImages(std::vector& mutableImages) { + if (!mRenderThread.getGrContext()) { + ALOGD("Trying to pin an image with an invalid GrContext"); + return false; + } for (SkImage* image : mutableImages) { if (SkImage_pinAsTexture(image, mRenderThread.getGrContext())) { mPinnedImages.emplace_back(sk_ref_sp(image));