From 33e714af1cd0f8fc5e52da86f06753c987a9af15 Mon Sep 17 00:00:00 2001 From: Sally Date: Mon, 14 Feb 2022 22:42:33 +0000 Subject: [PATCH] Use isAggregatedVisible for pane events When the pane title changes, the view may not be actually visible on screen. Check parent visibility before sending a pane event. Bug: 133131221 Test: manual check to ensure we don't receive title event, atest AccessibilityPaneTest Change-Id: I8bad8f742cc3e8f4d906c2b6fe80a3516c900ef1 --- core/java/android/view/View.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 286b502791c80..34a13868f4d74 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -14173,7 +14173,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback, && isAccessibilityPane()) { // If the pane isn't visible, content changed events are sufficient unless we're // reporting that the view just disappeared - if ((getVisibility() == VISIBLE) + if ((isAggregatedVisible()) || (changeType == AccessibilityEvent.CONTENT_CHANGE_TYPE_PANE_DISAPPEARED)) { final AccessibilityEvent event = AccessibilityEvent.obtain(); onInitializeAccessibilityEvent(event);