From 33cea00de9ee3982cdd4658f661454cba003038e Mon Sep 17 00:00:00 2001 From: Chilun Huang Date: Wed, 21 Dec 2022 14:43:38 +0800 Subject: [PATCH] Add FlakyTest annotation on correct test This fixs commit I2065ae54d536bf7a7eabdb7a920edc76fe32aeb9 Fix: 263148628 Bug: 263213649 Test: atest WMShellFlickerTests:DragDividerToResize Change-Id: I886e38845cdcbabb9538d5620195f04304378c88 --- .../splitscreen/DragDividerToResize.kt | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/splitscreen/DragDividerToResize.kt b/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/splitscreen/DragDividerToResize.kt index 0160f18d1d359..73671dbb3c6fc 100644 --- a/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/splitscreen/DragDividerToResize.kt +++ b/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/splitscreen/DragDividerToResize.kt @@ -85,7 +85,18 @@ class DragDividerToResize(flicker: FlickerTest) : SplitScreenBase(flicker) { @Test fun splitScreenDividerKeepVisible() = flicker.layerKeepVisible(SPLIT_SCREEN_DIVIDER_COMPONENT) - @Presubmit @Test fun primaryAppLayerKeepVisible() = flicker.layerKeepVisible(primaryApp) + @Presubmit + @Test + fun primaryAppLayerKeepVisible() { + Assume.assumeFalse(isShellTransitionsEnabled) + flicker.layerKeepVisible(primaryApp) + } + + @FlakyTest(bugId = 263213649) + @Test fun primaryAppLayerKeepVisible_ShellTransit() { + Assume.assumeTrue(isShellTransitionsEnabled) + flicker.layerKeepVisible(primaryApp) + } @Presubmit @Test @@ -99,17 +110,7 @@ class DragDividerToResize(flicker: FlickerTest) : SplitScreenBase(flicker) { } } - @Presubmit - @Test fun primaryAppWindowKeepVisible() { - Assume.assumeFalse(isShellTransitionsEnabled) - flicker.appWindowKeepVisible(primaryApp) - } - - @FlakyTest(bugId = 263213649) - @Test fun primaryAppWindowKeepVisible_ShellTransit() { - Assume.assumeTrue(isShellTransitionsEnabled) - flicker.appWindowKeepVisible(primaryApp) - } + @Presubmit @Test fun primaryAppWindowKeepVisible() = flicker.appWindowKeepVisible(primaryApp) @Presubmit @Test