diff --git a/packages/SystemUI/customization/src/com/android/systemui/shared/clocks/DefaultClockController.kt b/packages/SystemUI/customization/src/com/android/systemui/shared/clocks/DefaultClockController.kt index e539c955a3c68..e7a53e5baaf43 100644 --- a/packages/SystemUI/customization/src/com/android/systemui/shared/clocks/DefaultClockController.kt +++ b/packages/SystemUI/customization/src/com/android/systemui/shared/clocks/DefaultClockController.kt @@ -62,6 +62,7 @@ class DefaultClockController( private val burmeseLineSpacing = resources.getFloat(R.dimen.keyguard_clock_line_spacing_scale_burmese) private val defaultLineSpacing = resources.getFloat(R.dimen.keyguard_clock_line_spacing_scale) + protected var onSecondaryDisplay: Boolean = false override val events: DefaultClockEvents override val config = ClockConfig() @@ -142,6 +143,11 @@ class DefaultClockController( view.setTextSize(TypedValue.COMPLEX_UNIT_PX, fontSizePx) recomputePadding(targetRegion) } + + override fun onSecondaryDisplayChanged(onSecondaryDisplay: Boolean) { + this@DefaultClockController.onSecondaryDisplay = onSecondaryDisplay + recomputePadding(null) + } } open fun recomputePadding(targetRegion: Rect?) {} @@ -182,13 +188,19 @@ class DefaultClockController( override fun recomputePadding(targetRegion: Rect?) { // We center the view within the targetRegion instead of within the parent // view by computing the difference and adding that to the padding. - val parent = view.parent - val yDiff = - if (targetRegion != null && parent is View && parent.isLaidOut()) - targetRegion.centerY() - parent.height / 2f - else 0f val lp = view.getLayoutParams() as FrameLayout.LayoutParams - lp.topMargin = (-0.5f * view.bottom + yDiff).toInt() + lp.topMargin = + if (onSecondaryDisplay) { + // On the secondary display we don't want any additional top/bottom margin. + 0 + } else { + val parent = view.parent + val yDiff = + if (targetRegion != null && parent is View && parent.isLaidOut()) + targetRegion.centerY() - parent.height / 2f + else 0f + (-0.5f * view.bottom + yDiff).toInt() + } view.setLayoutParams(lp) } diff --git a/packages/SystemUI/plugin/src/com/android/systemui/plugins/ClockProviderPlugin.kt b/packages/SystemUI/plugin/src/com/android/systemui/plugins/ClockProviderPlugin.kt index d962732ba884c..527f800722222 100644 --- a/packages/SystemUI/plugin/src/com/android/systemui/plugins/ClockProviderPlugin.kt +++ b/packages/SystemUI/plugin/src/com/android/systemui/plugins/ClockProviderPlugin.kt @@ -177,6 +177,9 @@ interface ClockFaceEvents { * targetRegion is relative to the parent view. */ fun onTargetRegionChanged(targetRegion: Rect?) + + /** Called to notify the clock about its display. */ + fun onSecondaryDisplayChanged(onSecondaryDisplay: Boolean) } /** Tick rates for clocks */ diff --git a/packages/SystemUI/res-keyguard/layout/keyguard_clock_presentation.xml b/packages/SystemUI/res-keyguard/layout/keyguard_clock_presentation.xml new file mode 100644 index 0000000000000..593f507f3c88a --- /dev/null +++ b/packages/SystemUI/res-keyguard/layout/keyguard_clock_presentation.xml @@ -0,0 +1,37 @@ + + + + + + + + + diff --git a/packages/SystemUI/src/com/android/keyguard/ConnectedDisplayKeyguardPresentation.kt b/packages/SystemUI/src/com/android/keyguard/ConnectedDisplayKeyguardPresentation.kt new file mode 100644 index 0000000000000..899cad89a0bea --- /dev/null +++ b/packages/SystemUI/src/com/android/keyguard/ConnectedDisplayKeyguardPresentation.kt @@ -0,0 +1,85 @@ +/* + * Copyright (C) 2023 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.keyguard + +import android.app.Presentation +import android.content.Context +import android.graphics.Color +import android.os.Bundle +import android.view.Display +import android.view.LayoutInflater +import android.view.View +import android.view.WindowManager +import com.android.keyguard.dagger.KeyguardStatusViewComponent +import com.android.systemui.R +import dagger.assisted.Assisted +import dagger.assisted.AssistedFactory +import dagger.assisted.AssistedInject + +/** [Presentation] shown in connected displays while on keyguard. */ +class ConnectedDisplayKeyguardPresentation +@AssistedInject +constructor( + @Assisted display: Display, + context: Context, + private val keyguardStatusViewComponentFactory: KeyguardStatusViewComponent.Factory, +) : + Presentation( + context, + display, + R.style.Theme_SystemUI_KeyguardPresentation, + WindowManager.LayoutParams.TYPE_KEYGUARD_DIALOG + ) { + + private lateinit var keyguardStatusViewController: KeyguardStatusViewController + private lateinit var clock: KeyguardStatusView + + override fun onCreate(savedInstanceState: Bundle?) { + super.onCreate(savedInstanceState) + + setContentView( + LayoutInflater.from(context) + .inflate(R.layout.keyguard_clock_presentation, /* root= */ null) + ) + val window = window ?: error("no window available.") + + // Logic to make the lock screen fullscreen + window.decorView.systemUiVisibility = + (View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN or + View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION or + View.SYSTEM_UI_FLAG_LAYOUT_STABLE) + window.attributes.fitInsetsTypes = 0 + window.isNavigationBarContrastEnforced = false + window.navigationBarColor = Color.TRANSPARENT + + clock = findViewById(R.id.clock) + keyguardStatusViewController = + keyguardStatusViewComponentFactory.build(clock).keyguardStatusViewController.apply { + setDisplayedOnSecondaryDisplay() + init() + } + } + + /** [ConnectedDisplayKeyguardPresentation] factory. */ + @AssistedFactory + interface Factory { + /** Creates a new [Presentation] for the given [display]. */ + fun create( + display: Display, + ): ConnectedDisplayKeyguardPresentation + } +} diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardClockSwitch.java b/packages/SystemUI/src/com/android/keyguard/KeyguardClockSwitch.java index b4f195654780d..5915b22c9a5f9 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardClockSwitch.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardClockSwitch.java @@ -1,10 +1,5 @@ package com.android.keyguard; -import static android.view.View.ALPHA; -import static android.view.View.SCALE_X; -import static android.view.View.SCALE_Y; -import static android.view.View.TRANSLATION_Y; - import static com.android.keyguard.KeyguardStatusAreaView.TRANSLATE_X_CLOCK_DESIGN; import static com.android.keyguard.KeyguardStatusAreaView.TRANSLATE_Y_CLOCK_DESIGN; import static com.android.keyguard.KeyguardStatusAreaView.TRANSLATE_Y_CLOCK_SIZE; @@ -145,6 +140,13 @@ public class KeyguardClockSwitch extends RelativeLayout { updateStatusArea(/* animate= */false); } + /** Sets whether the large clock is being shown on a connected display. */ + public void setLargeClockOnSecondaryDisplay(boolean onSecondaryDisplay) { + if (mClock != null) { + mClock.getLargeClock().getEvents().onSecondaryDisplayChanged(onSecondaryDisplay); + } + } + /** * Enable or disable split shade specific positioning */ diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardClockSwitchController.java b/packages/SystemUI/src/com/android/keyguard/KeyguardClockSwitchController.java index 21d8c0af56853..81080760822b2 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardClockSwitchController.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardClockSwitchController.java @@ -104,6 +104,7 @@ public class KeyguardClockSwitchController extends ViewController mNavigationBarControllerLazy; private final KeyguardStatusViewComponent.Factory mKeyguardStatusViewComponentFactory; + private final ConnectedDisplayKeyguardPresentation.Factory + mConnectedDisplayKeyguardPresentationFactory; + private final FeatureFlags mFeatureFlags; private final Context mContext; private boolean mShowing; @@ -105,7 +111,10 @@ public class KeyguardDisplayManager { @Main Executor mainExecutor, @UiBackground Executor uiBgExecutor, DeviceStateHelper deviceStateHelper, - KeyguardStateController keyguardStateController) { + KeyguardStateController keyguardStateController, + ConnectedDisplayKeyguardPresentation.Factory + connectedDisplayKeyguardPresentationFactory, + FeatureFlags featureFlags) { mContext = context; mNavigationBarControllerLazy = navigationBarControllerLazy; mKeyguardStatusViewComponentFactory = keyguardStatusViewComponentFactory; @@ -115,6 +124,8 @@ public class KeyguardDisplayManager { mDisplayTracker.addDisplayChangeCallback(mDisplayCallback, mainExecutor); mDeviceStateHelper = deviceStateHelper; mKeyguardStateController = keyguardStateController; + mConnectedDisplayKeyguardPresentationFactory = connectedDisplayKeyguardPresentationFactory; + mFeatureFlags = featureFlags; } private boolean isKeyguardShowable(Display display) { @@ -185,8 +196,12 @@ public class KeyguardDisplayManager { return false; } - KeyguardPresentation createPresentation(Display display) { - return new KeyguardPresentation(mContext, display, mKeyguardStatusViewComponentFactory); + Presentation createPresentation(Display display) { + if (mFeatureFlags.isEnabled(Flags.ENABLE_CLOCK_KEYGUARD_PRESENTATION)) { + return mConnectedDisplayKeyguardPresentationFactory.create(display); + } else { + return new KeyguardPresentation(mContext, display, mKeyguardStatusViewComponentFactory); + } } /** diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardStatusViewController.java b/packages/SystemUI/src/com/android/keyguard/KeyguardStatusViewController.java index 757022dd153bb..c314586e4a219 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardStatusViewController.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardStatusViewController.java @@ -187,6 +187,11 @@ public class KeyguardStatusViewController extends ViewController mNavigationBarController, mKeyguardStatusViewComponentFactory, mDisplayTracker, mMainExecutor, - mBackgroundExecutor, mDeviceStateHelper, mKeyguardStateController)); + mBackgroundExecutor, mDeviceStateHelper, mKeyguardStateController, + mConnectedDisplayKeyguardPresentationFactory, mFakeFeatureFlags)); doReturn(mKeyguardPresentation).when(mManager).createPresentation(any()); + doReturn(mConnectedDisplayKeyguardPresentation).when( + mConnectedDisplayKeyguardPresentationFactory).create(any()); mDefaultDisplay = new Display(DisplayManagerGlobal.getInstance(), Display.DEFAULT_DISPLAY, new DisplayInfo(), DEFAULT_DISPLAY_ADJUSTMENTS); @@ -138,4 +150,15 @@ public class KeyguardDisplayManagerTest extends SysuiTestCase { when(mKeyguardStateController.isOccluded()).thenReturn(true); verify(mManager, never()).createPresentation(eq(mSecondaryDisplay)); } + + @Test + public void testShow_withClockPresentationFlagEnabled_presentationCreated() { + when(mManager.createPresentation(any())).thenCallRealMethod(); + mFakeFeatureFlags.set(ENABLE_CLOCK_KEYGUARD_PRESENTATION, true); + mDisplayTracker.setAllDisplays(new Display[]{mDefaultDisplay, mSecondaryDisplay}); + + mManager.show(); + + verify(mConnectedDisplayKeyguardPresentationFactory).create(eq(mSecondaryDisplay)); + } }