From 32922ca4dbcc7f51dffc4a28824f6e8b63c33d26 Mon Sep 17 00:00:00 2001 From: Matt Pietal Date: Wed, 29 May 2019 07:39:21 -0400 Subject: [PATCH] Sharesheet - Fix NPE on default app launch Turns out there's a secondary layout used by resolver which does not contain R.id.empty. Check for null. Bug: 133707284 Test: Open PDF file through resolver Change-Id: I311f1c1d2fa6edcebc81d9056755884b1585a7cb --- core/java/com/android/internal/app/ResolverActivity.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/core/java/com/android/internal/app/ResolverActivity.java b/core/java/com/android/internal/app/ResolverActivity.java index 538c81d541296..0a01beba659fd 100644 --- a/core/java/com/android/internal/app/ResolverActivity.java +++ b/core/java/com/android/internal/app/ResolverActivity.java @@ -383,9 +383,11 @@ public class ResolverActivity extends Activity { mSystemWindowInsets.right, 0); View emptyView = findViewById(R.id.empty); - emptyView.setPadding(0, 0, 0, mSystemWindowInsets.bottom - + getResources().getDimensionPixelSize( - R.dimen.chooser_edge_margin_normal) * 2); + if (emptyView != null) { + emptyView.setPadding(0, 0, 0, mSystemWindowInsets.bottom + + getResources().getDimensionPixelSize( + R.dimen.chooser_edge_margin_normal) * 2); + } if (mFooterSpacer == null) { mFooterSpacer = new Space(getApplicationContext());