From 134d0411537c0c03e2363fe4190b35bba6be7546 Mon Sep 17 00:00:00 2001 From: Joanne Chung Date: Tue, 23 Feb 2021 00:31:44 +0800 Subject: [PATCH] Fix NPE in AutofillManager when feature autofill is disabled When feature_autofill is not present on device IAutoFillManager service could be null. It is proposed to check service for null before trying to add client to prevent NPE. Bug: 180913556 Test: cts-tradefed run cts-dev -m CtsWidgetTestCases \ -t android.widget.cts.DatePickerTest#testPartsVisibilityInSpinnerMode Test: atest CtsAutoFillServiceTestCases Change-Id: I4d65fe4f664e37115d653e981094f1a52c1d97e8 --- core/java/android/view/autofill/AutofillManager.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/java/android/view/autofill/AutofillManager.java b/core/java/android/view/autofill/AutofillManager.java index decbf8c0c59e0..4f0c568989de3 100644 --- a/core/java/android/view/autofill/AutofillManager.java +++ b/core/java/android/view/autofill/AutofillManager.java @@ -1975,7 +1975,10 @@ public final class AutofillManager { if (client == null) { return false; } - + if (mService == null) { + Log.w(TAG, "Autofill service is null!"); + return false; + } if (mServiceClient == null) { mServiceClient = new AutofillManagerClient(this); try {