From 6e4fb34e27546c0ff96d1257233e5b702236658a Mon Sep 17 00:00:00 2001 From: Arunesh Mishra Date: Tue, 2 Jun 2015 13:23:41 -0700 Subject: [PATCH] Use config.xml parameters instead of System properties. For 'near-ultrasound' support (mic/speaker). Refer b/21072209 for details. Bug: 21072209 Change-Id: Id7131cd38288d74af8102487b2c6b03048b4ae3b --- core/res/res/values/config.xml | 9 +++++++++ core/res/res/values/symbols.xml | 2 ++ media/java/android/media/AudioManager.java | 21 ++++++--------------- 3 files changed, 17 insertions(+), 15 deletions(-) diff --git a/core/res/res/values/config.xml b/core/res/res/values/config.xml index 8066d9f2b2166..beda9f4fcd688 100755 --- a/core/res/res/values/config.xml +++ b/core/res/res/values/config.xml @@ -2169,4 +2169,13 @@ Defaults to the older, deprecated config_windowIsRound already used in some existing device-specific resource overlays. --> @bool/config_windowIsRound + + + + true + + true + diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index 93fcb2f5437e2..50f97e3699411 100755 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -301,6 +301,8 @@ + + diff --git a/media/java/android/media/AudioManager.java b/media/java/android/media/AudioManager.java index 316ccf6cd2478..33db9cf3d8a70 100644 --- a/media/java/android/media/AudioManager.java +++ b/media/java/android/media/AudioManager.java @@ -38,7 +38,6 @@ import android.os.Looper; import android.os.Message; import android.os.Process; import android.os.RemoteException; -import android.os.SystemProperties; import android.os.SystemClock; import android.os.ServiceManager; import android.provider.Settings; @@ -68,16 +67,6 @@ public class AudioManager { private static String TAG = "AudioManager"; private static final AudioPortEventHandler sAudioPortEventHandler = new AudioPortEventHandler(); - /** - * System properties for whether the default microphone and speaker paths support - * near-ultrasound frequencies (range of 18 - 21 kHz). - */ - private static final String SYSTEM_PROPERTY_MIC_NEAR_ULTRASOUND = - "persist.audio.mic.ultrasound"; - private static final String SYSTEM_PROPERTY_SPEAKER_NEAR_ULTRASOUND = - "persist.audio.spkr.ultrasound"; - private static final String DEFAULT_RESULT_FALSE_STRING = "false"; - /** * Broadcast intent, a hint for applications that audio is about to become * 'noisy' due to a change in audio outputs. For example, this intent may @@ -3213,11 +3202,13 @@ public class AudioManager { int outputFramesPerBuffer = AudioSystem.getPrimaryOutputFrameCount(); return outputFramesPerBuffer > 0 ? Integer.toString(outputFramesPerBuffer) : null; } else if (PROPERTY_SUPPORT_MIC_NEAR_ULTRASOUND.equals(key)) { - return SystemProperties.get(SYSTEM_PROPERTY_MIC_NEAR_ULTRASOUND, - DEFAULT_RESULT_FALSE_STRING); + // Will throw a RuntimeException Resources.NotFoundException if this config value is + // not found. + return String.valueOf(getContext().getResources().getBoolean( + com.android.internal.R.bool.config_supportMicNearUltrasound)); } else if (PROPERTY_SUPPORT_SPEAKER_NEAR_ULTRASOUND.equals(key)) { - return SystemProperties.get(SYSTEM_PROPERTY_SPEAKER_NEAR_ULTRASOUND, - DEFAULT_RESULT_FALSE_STRING); + return String.valueOf(getContext().getResources().getBoolean( + com.android.internal.R.bool.config_supportSpeakerNearUltrasound)); } else { // null or unknown key return null;