From 1c0b2326b89b011ef16d9b6654f758b0b28eaea6 Mon Sep 17 00:00:00 2001
From: Tomasz Mikolajewski <mtomasz@google.com>
Date: Thu, 4 Feb 2016 11:50:45 +0900
Subject: [PATCH] Fix flaky testLoadsHomebyDefault.

The test was resuming a previously opened activity, so naturally the
redirect to Home didn't happen.

This CL fixes the issue by closing the activity in TearDown().

Change-Id: I43e78a83c2b53c52745bc7eef515a8f759559e46
---
 .../com/android/documentsui/FilesActivityUiTest.java   | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/packages/DocumentsUI/tests/src/com/android/documentsui/FilesActivityUiTest.java b/packages/DocumentsUI/tests/src/com/android/documentsui/FilesActivityUiTest.java
index 2535a80eb37e0..cedd13c618d39 100644
--- a/packages/DocumentsUI/tests/src/com/android/documentsui/FilesActivityUiTest.java
+++ b/packages/DocumentsUI/tests/src/com/android/documentsui/FilesActivityUiTest.java
@@ -53,6 +53,7 @@ public class FilesActivityUiTest extends InstrumentationTestCase {
     private ContentProviderClient mClient;
     private RootInfo mRoot_0;
     private RootInfo mRoot_1;
+    private FilesActivity mActivity;
 
     public void setUp() throws Exception {
         // Initialize UiDevice instance.
@@ -76,7 +77,8 @@ public class FilesActivityUiTest extends InstrumentationTestCase {
         // Launch app.
         Intent intent = mContext.getPackageManager().getLaunchIntentForPackage(TARGET_PKG);
         intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK);
-        mContext.startActivity(intent);
+        mActivity = launchActivityWithIntent(TARGET_PKG, FilesActivity.class, intent);
+        assertNotNull("Activity not started.", mActivity);
 
         // Wait for the app to appear.
         mDevice.wait(Until.hasObject(By.pkg(TARGET_PKG).depth(0)), TIMEOUT);
@@ -90,6 +92,12 @@ public class FilesActivityUiTest extends InstrumentationTestCase {
     @Override
     protected void tearDown() throws Exception {
         super.tearDown();
+
+        if (mActivity != null) {
+            mActivity.finish();
+            mActivity = null;
+        }
+
         Log.d(TAG, "Resetting storage from setUp");
         resetStorage();
         mClient.release();