From 30b6a20c99d043e36d41851d80250bfdf2810556 Mon Sep 17 00:00:00 2001 From: Yao Chen Date: Sat, 18 Nov 2017 14:14:38 -0800 Subject: [PATCH] Don't just clear mPastBuckets when onDumpReport is called. This needs to be done properly. Left a TODO. Test: statsd_test Change-Id: I8537f0a870ab82039e0822c69096784403ee1651 --- cmds/statsd/src/metrics/DurationMetricProducer.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cmds/statsd/src/metrics/DurationMetricProducer.cpp b/cmds/statsd/src/metrics/DurationMetricProducer.cpp index 581ca410e1dc4..8d2c9f4bb95f2 100644 --- a/cmds/statsd/src/metrics/DurationMetricProducer.cpp +++ b/cmds/statsd/src/metrics/DurationMetricProducer.cpp @@ -222,10 +222,8 @@ std::unique_ptr> DurationMetricProducer::onDumpReport() { (long long)mCurrentBucketStartTimeNs); std::unique_ptr> buffer = serializeProto(); - startNewProtoOutputStream(endTime); - mPastBuckets.clear(); - + // TODO: Properly clear the old buckets. return buffer; }