From a2b2535bd71317df91fa82d911e4a6a731041104 Mon Sep 17 00:00:00 2001 From: Bo Liu Date: Mon, 4 Feb 2019 23:05:44 +0000 Subject: [PATCH] Revert "Enable vulkan webview draw functor" This reverts commit dec730fda539fa941f7db1b9ed231a4585654dbe. Reason for revert: b/123877499 Change-Id: I14fc562c81f5ef5dab0f5404402b64858e54e364 --- libs/hwui/pipeline/skia/SkiaRecordingCanvas.cpp | 4 +++- native/webview/plat_support/draw_functor.cpp | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libs/hwui/pipeline/skia/SkiaRecordingCanvas.cpp b/libs/hwui/pipeline/skia/SkiaRecordingCanvas.cpp index b80a75d03a807..d54275fe7e19d 100644 --- a/libs/hwui/pipeline/skia/SkiaRecordingCanvas.cpp +++ b/libs/hwui/pipeline/skia/SkiaRecordingCanvas.cpp @@ -138,8 +138,10 @@ void SkiaRecordingCanvas::callDrawGLFunction(Functor* functor, void SkiaRecordingCanvas::drawWebViewFunctor(int functor) { FunctorDrawable* functorDrawable; if (Properties::getRenderPipelineType() == RenderPipelineType::SkiaVulkan) { + // TODO(cblume) use VkFunctorDrawable instead of VkInteropFunctorDrawable here when the + // interop is disabled. functorDrawable = - mDisplayList->allocateDrawable(functor, asSkCanvas()); + mDisplayList->allocateDrawable(functor, asSkCanvas()); } else { functorDrawable = mDisplayList->allocateDrawable(functor, asSkCanvas()); } diff --git a/native/webview/plat_support/draw_functor.cpp b/native/webview/plat_support/draw_functor.cpp index af2d0c8509656..b97bbc3116244 100644 --- a/native/webview/plat_support/draw_functor.cpp +++ b/native/webview/plat_support/draw_functor.cpp @@ -163,6 +163,9 @@ int CreateFunctor(void* data, AwDrawFnFunctorCallbacks* functor_callbacks) { webview_functor_callbacks.vk.initialize = &initializeVk; webview_functor_callbacks.vk.draw = &drawVk; webview_functor_callbacks.vk.postDraw = &postDrawVk; + // TODO(boliu): Remove this once SkiaRecordingCanvas::drawWebViewFunctor + // no longer uses GL interop. + webview_functor_callbacks.gles.draw = &draw_gl; break; } callbacks_initialized = true;