Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug:3330569 print better message to help debug the problem

Browse Source 
methods such as SQLiteStatement.simpleQueryForString() expect
one and only row to be returned when the query is executed.
if the application provides a query that doesn't return any data,
then the error message printed is pretty confusing.

make it less confusing and print the query itself to help debug
the error.

Change-Id: Ife2066f3a3eab0b98845a49e8f72b518458a7757
This commit is contained in:
Vasu Nori
2011-01-10 14:29:04 -08:00
parent 817b3f9342
commit 3045bbaf58
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/java/android/database/sqlite/SQLiteStatement.java
View File

@@ -131,6 +131,10 @@ public class SQLiteStatement extends SQLiteProgram
long retValue = native_1x1_long();
mDatabase.logTimeStat(mSql, timeStart);
return retValue;
} catch (SQLiteDoneException e) {
throw new SQLiteDoneException(
"expected 1 row from this query but query returned no data. check the query: " +
mSql);
} finally {
releaseAndUnlock();
}
@@ -150,6 +154,10 @@ public class SQLiteStatement extends SQLiteProgram
String retValue = native_1x1_string();
mDatabase.logTimeStat(mSql, timeStart);
return retValue;
} catch (SQLiteDoneException e) {
throw new SQLiteDoneException(
"expected 1 row from this query but query returned no data. check the query: " +
mSql);
} finally {
releaseAndUnlock();
}
@@ -172,6 +180,10 @@ public class SQLiteStatement extends SQLiteProgram
} catch (IOException ex) {
Log.e(TAG, "simpleQueryForBlobFileDescriptor() failed", ex);
return null;
} catch (SQLiteDoneException e) {
throw new SQLiteDoneException(
"expected 1 row from this query but query returned no data. check the query: " +
mSql);
} finally {
releaseAndUnlock();
}