From 978f948ba32fa72e1c2af493f1376b5db1613359 Mon Sep 17 00:00:00 2001 From: Ashwini Oruganti Date: Sat, 5 Dec 2020 22:02:59 -0800 Subject: [PATCH] FaceAuthenticationClient: Mark unaudited PendingIntents with FLAG_MUTABLE_UNAUDITED These PIs need an explicit mutability flag. This temporay flag is being used to mark these points in code and should be replaced ASAP. See go/immutable-pendingintents for more context. Bug: 160794467 Test: TH Exempt-From-Owner-Approval: noop change Change-Id: I10ba5b1643ba444accb5c3fb39ca381e3f083415 --- .../sensors/face/hidl/FaceAuthenticationClient.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/biometrics/sensors/face/hidl/FaceAuthenticationClient.java b/services/core/java/com/android/server/biometrics/sensors/face/hidl/FaceAuthenticationClient.java index ce880aa8aeed0..cbffdd33fff06 100644 --- a/services/core/java/com/android/server/biometrics/sensors/face/hidl/FaceAuthenticationClient.java +++ b/services/core/java/com/android/server/biometrics/sensors/face/hidl/FaceAuthenticationClient.java @@ -198,9 +198,11 @@ class FaceAuthenticationClient extends AuthenticationClient { final Intent intent = new Intent("android.settings.FACE_SETTINGS"); intent.setPackage("com.android.settings"); + // TODO(b/174187097) Please replace FLAG_MUTABLE_UNAUDITED below + // with either FLAG_IMMUTABLE (recommended) or FLAG_MUTABLE. final PendingIntent pendingIntent = PendingIntent.getActivityAsUser(getContext(), - 0 /* requestCode */, intent, 0 /* flags */, null /* options */, - UserHandle.CURRENT); + 0 /* requestCode */, intent, PendingIntent.FLAG_MUTABLE_UNAUDITED /* flags */, + null /* options */, UserHandle.CURRENT); final String channelName = "FaceEnrollNotificationChannel";