Merge "[GWP-ASan] Enable recoverable GWP-ASan for apps."

This commit is contained in:
Mitch Phillips
2023-02-14 18:50:00 +00:00
committed by Gerrit Code Review

View File

@@ -1923,15 +1923,16 @@ static void SpecializeCommon(JNIEnv* env, uid_t uid, gid_t gid, jintArray gids,
const char* nice_name_ptr = nice_name.has_value() ? nice_name.value().c_str() : nullptr; const char* nice_name_ptr = nice_name.has_value() ? nice_name.value().c_str() : nullptr;
android_mallopt_gwp_asan_options_t gwp_asan_options; android_mallopt_gwp_asan_options_t gwp_asan_options;
const char* kGwpAsanAppRecoverableSysprop =
"persist.device_config.memory_safety_native.gwp_asan_recoverable_apps";
// The system server doesn't have its nice name set by the time SpecializeCommon is called. // The system server doesn't have its nice name set by the time SpecializeCommon is called.
gwp_asan_options.program_name = nice_name_ptr ?: process_name; gwp_asan_options.program_name = nice_name_ptr ?: process_name;
switch (runtime_flags & RuntimeFlags::GWP_ASAN_LEVEL_MASK) { switch (runtime_flags & RuntimeFlags::GWP_ASAN_LEVEL_MASK) {
default: default:
case RuntimeFlags::GWP_ASAN_LEVEL_DEFAULT: case RuntimeFlags::GWP_ASAN_LEVEL_DEFAULT:
// TODO(b/247012630): Switch this to Action::TURN_ON_FOR_APP_SAMPLED_NON_CRASHING once gwp_asan_options.desire = GetBoolProperty(kGwpAsanAppRecoverableSysprop, true)
// performance and syshealth testing is completed, making the default for non-system ? Action::TURN_ON_FOR_APP_SAMPLED_NON_CRASHING
// apps that don't specify a `gwpAsanMode` in their manifest to be sampled-recoverable. : Action::DONT_TURN_ON_UNLESS_OVERRIDDEN;
gwp_asan_options.desire = Action::DONT_TURN_ON_UNLESS_OVERRIDDEN;
android_mallopt(M_INITIALIZE_GWP_ASAN, &gwp_asan_options, sizeof(gwp_asan_options)); android_mallopt(M_INITIALIZE_GWP_ASAN, &gwp_asan_options, sizeof(gwp_asan_options));
break; break;
case RuntimeFlags::GWP_ASAN_LEVEL_NEVER: case RuntimeFlags::GWP_ASAN_LEVEL_NEVER: