From f535f9e2e9e44eb340c20b1fde0f3eba90bd3e78 Mon Sep 17 00:00:00 2001 From: Alex Dadukin Date: Tue, 27 Sep 2022 12:40:11 +0000 Subject: [PATCH] Implement dump method in RouteDiscoveryPreference Bug: b/243116883 Test: adb shell dumpsys media_router Change-Id: I17c504b9847513b2ad84eaa6a888a741223ac6d9 --- .../media/RouteDiscoveryPreference.java | 20 +++++++++++++++++++ .../server/media/MediaRouter2ServiceImpl.java | 4 ++++ 2 files changed, 24 insertions(+) diff --git a/media/java/android/media/RouteDiscoveryPreference.java b/media/java/android/media/RouteDiscoveryPreference.java index 207460af140c5..71d8261b09bfc 100644 --- a/media/java/android/media/RouteDiscoveryPreference.java +++ b/media/java/android/media/RouteDiscoveryPreference.java @@ -24,6 +24,8 @@ import android.os.Parcel; import android.os.Parcelable; import android.text.TextUtils; +import java.io.FileDescriptor; +import java.io.PrintWriter; import java.util.Collection; import java.util.Collections; import java.util.HashSet; @@ -180,6 +182,24 @@ public final class RouteDiscoveryPreference implements Parcelable { dest.writeBundle(mExtras); } + /** + * Dumps current state of the instance. Use with {@code dumpsys}. + * + * See {@link android.os.Binder#dump(FileDescriptor, PrintWriter, String[])}. + * + * @hide + */ + public void dump(@NonNull PrintWriter pw, @NonNull String prefix) { + pw.println(prefix + "RouteDiscoveryPreference"); + + String indent = prefix + " "; + + pw.println(indent + "mPreferredFeatures=" + mPreferredFeatures); + pw.println(indent + "mPackageOrder=" + mPackageOrder); + pw.println(indent + "mAllowedPackages=" + mAllowedPackages); + pw.println(indent + "mExtras=" + mExtras); + } + @Override public String toString() { StringBuilder result = new StringBuilder() diff --git a/services/core/java/com/android/server/media/MediaRouter2ServiceImpl.java b/services/core/java/com/android/server/media/MediaRouter2ServiceImpl.java index 82b5c11cfb8ca..fb94d6e87071f 100644 --- a/services/core/java/com/android/server/media/MediaRouter2ServiceImpl.java +++ b/services/core/java/com/android/server/media/MediaRouter2ServiceImpl.java @@ -1243,6 +1243,8 @@ class MediaRouter2ServiceImpl { pw.println(indent + ""); } + mCompositeDiscoveryPreference.dump(pw, indent); + if (!mHandler.runWithScissors(() -> mHandler.dump(pw, indent), 1000)) { pw.println(indent + ""); } @@ -1301,6 +1303,8 @@ class MediaRouter2ServiceImpl { pw.println(indent + "mHasModifyAudioRoutingPermission=" + mHasModifyAudioRoutingPermission); pw.println(indent + "mRouterId=" + mRouterId); + + mDiscoveryPreference.dump(pw, indent); } }