From 3ff4226363c9f87fb5d0792fabad66034fb28614 Mon Sep 17 00:00:00 2001 From: Wan He Date: Thu, 17 Nov 2016 17:49:37 +0800 Subject: [PATCH] Fix incorrect calculation of sizeof package structure Argument "package" is a pointer, not the structure. Signed-off-by: Wan He --- libs/androidfw/ResourceTypes.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/androidfw/ResourceTypes.cpp b/libs/androidfw/ResourceTypes.cpp index fd30c25bec412..e10db05e8557b 100644 --- a/libs/androidfw/ResourceTypes.cpp +++ b/libs/androidfw/ResourceTypes.cpp @@ -3166,7 +3166,7 @@ struct ResTable::Package { Package(ResTable* _owner, const Header* _header, const ResTable_package* _package) : owner(_owner), header(_header), package(_package), typeIdOffset(0) { - if (dtohs(package->header.headerSize) == sizeof(package)) { + if (dtohs(package->header.headerSize) == sizeof(*package)) { // The package structure is the same size as the definition. // This means it contains the typeIdOffset field. typeIdOffset = package->typeIdOffset;