From 2ecbc7acdb6f87e34228e67e36333f64eb021f82 Mon Sep 17 00:00:00 2001 From: Jerry Zhang Date: Mon, 26 Mar 2018 14:59:39 -0700 Subject: [PATCH] Guard against null server If MtpService stops before MtpServer shuts down, the server will be null, so don't attempt to use it in that case. Bug: 76433619 Test: no errors Change-Id: I6744cb78908e6a0663a4b60107d5c9c18dda62bb --- media/java/android/mtp/MtpDatabase.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/media/java/android/mtp/MtpDatabase.java b/media/java/android/mtp/MtpDatabase.java index 32a00d597e624..f15de2c157929 100755 --- a/media/java/android/mtp/MtpDatabase.java +++ b/media/java/android/mtp/MtpDatabase.java @@ -314,7 +314,9 @@ public class MtpDatabase implements AutoCloseable { public void addStorage(StorageVolume storage) { MtpStorage mtpStorage = mManager.addMtpStorage(storage); mStorageMap.put(storage.getPath(), mtpStorage); - mServer.addStorage(mtpStorage); + if (mServer != null) { + mServer.addStorage(mtpStorage); + } } public void removeStorage(StorageVolume storage) { @@ -322,7 +324,9 @@ public class MtpDatabase implements AutoCloseable { if (mtpStorage == null) { return; } - mServer.removeStorage(mtpStorage); + if (mServer != null) { + mServer.removeStorage(mtpStorage); + } mManager.removeMtpStorage(mtpStorage); mStorageMap.remove(storage.getPath()); }