From dda938a698a17b2943bbe78f6631a26dedabf28a Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Fri, 2 Dec 2016 12:17:21 -0700 Subject: [PATCH] DO NOT MERGE: Switch over to new "time.android.com" NTP pool. Also add logging to measure success/failure details. Test: builds, boots, and NTP fix obtained Bug: 32969463 (cherry picked from commit d3f689bf14a05de735b5cc92dcf20e7226c78690) Change-Id: I7da416099ae903fd92beb516251ef4e51673eecf --- Android.mk | 1 + core/java/android/net/EventLogTags.logtags | 6 ++++++ core/java/android/net/SntpClient.java | 6 ++++-- core/res/res/values/config.xml | 2 +- 4 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 core/java/android/net/EventLogTags.logtags diff --git a/Android.mk b/Android.mk index c0bb7240c796b..da26622c62eca 100644 --- a/Android.mk +++ b/Android.mk @@ -45,6 +45,7 @@ LOCAL_SRC_FILES += \ core/java/android/app/admin/SecurityLogTags.logtags \ core/java/android/content/EventLogTags.logtags \ core/java/android/speech/tts/EventLogTags.logtags \ + core/java/android/net/EventLogTags.logtags \ core/java/android/webkit/EventLogTags.logtags \ core/java/com/android/internal/logging/EventLogTags.logtags \ diff --git a/core/java/android/net/EventLogTags.logtags b/core/java/android/net/EventLogTags.logtags new file mode 100644 index 0000000000000..d5ed01496eba6 --- /dev/null +++ b/core/java/android/net/EventLogTags.logtags @@ -0,0 +1,6 @@ +# See system/core/logcat/event.logtags for a description of the format of this file. + +option java_package android.net + +50080 ntp_success (server|3),(rtt|2),(offset|2) +50081 ntp_failure (server|3),(msg|3) diff --git a/core/java/android/net/SntpClient.java b/core/java/android/net/SntpClient.java index cf9243f7e7a31..cea56b53d7637 100644 --- a/core/java/android/net/SntpClient.java +++ b/core/java/android/net/SntpClient.java @@ -36,8 +36,7 @@ import java.util.Arrays; * } * */ -public class SntpClient -{ +public class SntpClient { private static final String TAG = "SntpClient"; private static final boolean DBG = true; @@ -88,6 +87,7 @@ public class SntpClient try { address = InetAddress.getByName(host); } catch (Exception e) { + EventLogTags.writeNtpFailure(host, e.toString()); if (DBG) Log.d(TAG, "request time failed: " + e); return false; } @@ -142,6 +142,7 @@ public class SntpClient // = (transit + skew - transit + skew)/2 // = (2 * skew)/2 = skew long clockOffset = ((receiveTime - originateTime) + (transmitTime - responseTime))/2; + EventLogTags.writeNtpSuccess(address.toString(), roundTripTime, clockOffset); if (DBG) { Log.d(TAG, "round trip: " + roundTripTime + "ms, " + "clock offset: " + clockOffset + "ms"); @@ -153,6 +154,7 @@ public class SntpClient mNtpTimeReference = responseTicks; mRoundTripTime = roundTripTime; } catch (Exception e) { + EventLogTags.writeNtpFailure(address.toString(), e.toString()); if (DBG) Log.d(TAG, "request time failed: " + e); return false; } finally { diff --git a/core/res/res/values/config.xml b/core/res/res/values/config.xml index 22255b493ab2f..25021b8deeed8 100644 --- a/core/res/res/values/config.xml +++ b/core/res/res/values/config.xml @@ -1681,7 +1681,7 @@ true - 2.android.pool.ntp.org + time.android.com 86400000