Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

LoadedApk: Don't set up JIT profile support inside the system_server.

Browse Source 
We shouldn't profile *any* packages loaded by the system_server, not
just the system_servers own ("android") package.

bug: 28241500
Change-Id: I5f3f477b40c758030a5bdc8e97d17cab6e68e204
This commit is contained in:
Narayan Kamath
2016-04-25 19:16:56 +01:00
parent 5bc7f5f01b
commit 2d4a222de1
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/java/android/app/LoadedApk.java
View File

@@ -510,11 +510,15 @@ public final class LoadedApk {
} }
// Setup jit profile support. // Setup jit profile support.
//
// It is ok to call this multiple times if the application gets updated with new splits. // It is ok to call this multiple times if the application gets updated with new splits.
// The runtime only keeps track of unique code paths and can handle re-registration of // The runtime only keeps track of unique code paths and can handle re-registration of
// the same code path. There's no need to pass `addedPaths` since any new code paths // the same code path. There's no need to pass `addedPaths` since any new code paths
// are already in `mApplicationInfo`. // are already in `mApplicationInfo`.
if (needToSetupJitProfiles) { //
// It is NOT ok to call this function from the system_server (for any of the packages it
// loads code from) so we explicitly disallow it there.
if (needToSetupJitProfiles && !ActivityThread.isSystem()) {
// Temporarily disable logging of disk reads/writes on the Looper thread // Temporarily disable logging of disk reads/writes on the Looper thread
// as this is early and necessary. Write is only needed to create the // as this is early and necessary. Write is only needed to create the
// profile file if it's not already there. // profile file if it's not already there.