From 2cf8ba50bb9d397932c873d2d0c5352aa5e0cf02 Mon Sep 17 00:00:00 2001 From: Beth Thibodeau Date: Thu, 16 Dec 2021 18:36:43 -0500 Subject: [PATCH] Add new layout for session based media players When the flag is enabled to use session-based actions, use the alternate layout as well. This layout has only one size and will show all controls regardless of location. Bug: 209657555 Bug: 209655299 Test: atest Test: manual - flip flag and check player layout Change-Id: I3d048d52cdd11872d40f7735892f3e6c83462950 --- .../qs_media_round_button_background.xml | 25 ++ .../res/layout/media_session_view.xml | 313 ++++++++++++++++ packages/SystemUI/res/values/dimens.xml | 4 + packages/SystemUI/res/values/styles.xml | 17 + .../systemui/media/MediaCarouselController.kt | 23 +- .../media/MediaCarouselScrollHandler.kt | 2 +- .../systemui/media/MediaControlPanel.java | 336 ++++++++++-------- .../systemui/media/MediaViewController.kt | 70 ++-- .../android/systemui/media/MediaViewHolder.kt | 80 +++++ .../systemui/media/PlayerSessionViewHolder.kt | 104 ++++++ .../systemui/media/PlayerViewHolder.kt | 46 +-- .../android/systemui/media/SeekBarObserver.kt | 31 +- .../media/MediaCarouselControllerTest.kt | 7 +- .../systemui/media/MediaControlPanelTest.kt | 185 ++++++---- .../systemui/media/SeekBarObserverTest.kt | 2 +- 15 files changed, 947 insertions(+), 298 deletions(-) create mode 100644 packages/SystemUI/res/drawable/qs_media_round_button_background.xml create mode 100644 packages/SystemUI/res/layout/media_session_view.xml create mode 100644 packages/SystemUI/src/com/android/systemui/media/MediaViewHolder.kt create mode 100644 packages/SystemUI/src/com/android/systemui/media/PlayerSessionViewHolder.kt diff --git a/packages/SystemUI/res/drawable/qs_media_round_button_background.xml b/packages/SystemUI/res/drawable/qs_media_round_button_background.xml new file mode 100644 index 0000000000000..33ad2d6101ef8 --- /dev/null +++ b/packages/SystemUI/res/drawable/qs_media_round_button_background.xml @@ -0,0 +1,25 @@ + + + + + + + + + + diff --git a/packages/SystemUI/res/layout/media_session_view.xml b/packages/SystemUI/res/layout/media_session_view.xml new file mode 100644 index 0000000000000..cc02fea84a337 --- /dev/null +++ b/packages/SystemUI/res/layout/media_session_view.xml @@ -0,0 +1,313 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/packages/SystemUI/res/values/dimens.xml b/packages/SystemUI/res/values/dimens.xml index 843c69fb1f497..a780e04aa51fb 100644 --- a/packages/SystemUI/res/values/dimens.xml +++ b/packages/SystemUI/res/values/dimens.xml @@ -969,6 +969,10 @@ 28dp 29dp + + 15dp + 16dp + 72dp 76dp diff --git a/packages/SystemUI/res/values/styles.xml b/packages/SystemUI/res/values/styles.xml index 9358349297831..18bfb52d3401f 100644 --- a/packages/SystemUI/res/values/styles.xml +++ b/packages/SystemUI/res/values/styles.xml @@ -581,6 +581,23 @@ centerInside + + + +