diff --git a/services/core/java/com/android/server/pm/PackageInstallerSession.java b/services/core/java/com/android/server/pm/PackageInstallerSession.java index 55a0c96eea9ed..28204eadd394c 100644 --- a/services/core/java/com/android/server/pm/PackageInstallerSession.java +++ b/services/core/java/com/android/server/pm/PackageInstallerSession.java @@ -706,9 +706,10 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { if (mCommitted.get()) { mStagingManager.abortCommittedSession(this); } - destroyInternal(); + destroy(); dispatchSessionFinished(INSTALL_FAILED_ABORTED, "Session was abandoned", null); - maybeCleanUpChildSessions(); + maybeFinishChildSessions(INSTALL_FAILED_ABORTED, + "Session was abandoned because the parent session is abandoned"); }; if (mStageDirInUse) { // Pre-reboot verification is ongoing, not safe to clean up the session yet. @@ -2131,6 +2132,7 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { destroy(); // Dispatch message to remove session from PackageInstallerService. dispatchSessionFinished(error, msg, null); + maybeFinishChildSessions(error, msg); } } @@ -3646,20 +3648,19 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { throw new SecurityException("Must be sealed to accept permissions"); } + PackageInstallerSession root = hasParentSessionId() + ? mSessionProvider.getSession(getParentSessionId()) : this; + if (accepted) { // Mark and kick off another install pass synchronized (mLock) { mPermissionsManuallyAccepted = true; } - - PackageInstallerSession root = - (hasParentSessionId()) - ? mSessionProvider.getSession(getParentSessionId()) - : this; root.mHandler.obtainMessage(MSG_INSTALL).sendToTarget(); } else { - destroyInternal(); - dispatchSessionFinished(INSTALL_FAILED_ABORTED, "User rejected permissions", null); + root.destroy(); + root.dispatchSessionFinished(INSTALL_FAILED_ABORTED, "User rejected permissions", null); + root.maybeFinishChildSessions(INSTALL_FAILED_ABORTED, "User rejected permissions"); } } @@ -3710,27 +3711,12 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { } /** - * Cleans up the relevant stored files and information of all child sessions. - *
Cleaning up the stored files and session information is necessary for - * preventing the orphan children sessions. - *