Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the usage of NETID_UNSET from Vpn.java

Browse Source 
Modify Vpn#getNetId() to Vpn#getNetwork() and uses NETID_UNSET
when getNetwork() returns null in ConnectivityServiceTest.

Bug: 182963397
Test: atest FrameworksNetTests
Change-Id: I69d449705b1dc541287c72af8dc7705dc4733109
This commit is contained in:
lucaslin
2021-03-22 15:10:20 +08:00
committed by Lucas Lin
parent b7eee43f50
commit 2cc371c74b
2 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
services/core/java/com/android/server/connectivity/Vpn.java
View File

@@ -17,7 +17,6 @@
package com.android.server.connectivity; package com.android.server.connectivity;
import static android.Manifest.permission.BIND_VPN_SERVICE; import static android.Manifest.permission.BIND_VPN_SERVICE;
import static android.net.ConnectivityManager.NETID_UNSET;
import static android.net.NetworkCapabilities.NET_CAPABILITY_NOT_METERED; import static android.net.NetworkCapabilities.NET_CAPABILITY_NOT_METERED;
import static android.net.RouteInfo.RTN_THROW; import static android.net.RouteInfo.RTN_THROW;
import static android.net.RouteInfo.RTN_UNREACHABLE; import static android.net.RouteInfo.RTN_UNREACHABLE;
@@ -1129,17 +1128,17 @@ public class Vpn {
} }
/** /**
* Return netId of current running VPN network. * Return Network of current running VPN network.
* *
* @return a netId if there is a running VPN network or NETID_UNSET if there is no running VPN * @return a Network if there is a running VPN network or null if there is no running VPN
* network or network is null. * network or network is null.
*/ */
public synchronized int getNetId() { public synchronized Network getNetwork() {
final NetworkAgent agent = mNetworkAgent; final NetworkAgent agent = mNetworkAgent;
if (null == agent) return NETID_UNSET; if (null == agent) return null;
final Network network = agent.getNetwork(); final Network network = agent.getNetwork();
if (null == network) return NETID_UNSET; if (null == network) return null;
return network.getNetId(); return network;
} }
private LinkProperties makeLinkProperties() { private LinkProperties makeLinkProperties() {

18
tests/net/java/com/android/server/ConnectivityServiceTest.java
View File

@@ -1177,11 +1177,6 @@ public class ConnectivityServiceTest {
return (mMockNetworkAgent == null) ? null : mMockNetworkAgent.getNetwork(); return (mMockNetworkAgent == null) ? null : mMockNetworkAgent.getNetwork();
} }
@Override
public int getNetId() {
return (mMockNetworkAgent == null) ? NETID_UNSET : mMockNetworkAgent.getNetwork().netId;
}
@Override @Override
public int getActiveVpnType() { public int getActiveVpnType() {
return mVpnType; return mVpnType;
@@ -1206,10 +1201,12 @@ public class ConnectivityServiceTest {
mNetworkCapabilities); mNetworkCapabilities);
mMockNetworkAgent.waitForIdle(TIMEOUT_MS); mMockNetworkAgent.waitForIdle(TIMEOUT_MS);
verify(mMockNetd, times(1)).networkAddUidRanges(eq(mMockVpn.getNetId()), final int expectedNetId = mMockVpn.getNetwork() == null ? NETID_UNSET
: mMockVpn.getNetwork().getNetId();
verify(mMockNetd, times(1)).networkAddUidRanges(eq(expectedNetId),
eq(toUidRangeStableParcels(uids))); eq(toUidRangeStableParcels(uids)));
verify(mMockNetd, never()) verify(mMockNetd, never())
.networkRemoveUidRanges(eq(mMockVpn.getNetId()), any()); .networkRemoveUidRanges(eq(expectedNetId), any());
mAgentRegistered = true; mAgentRegistered = true;
updateState(NetworkInfo.DetailedState.CONNECTED, "registerAgent"); updateState(NetworkInfo.DetailedState.CONNECTED, "registerAgent");
mNetworkCapabilities.set(mMockNetworkAgent.getNetworkCapabilities()); mNetworkCapabilities.set(mMockNetworkAgent.getNetworkCapabilities());
@@ -9744,11 +9741,14 @@ public class ConnectivityServiceTest {
exemptUidCaptor.capture()); exemptUidCaptor.capture());
assertContainsExactly(exemptUidCaptor.getValue(), Process.VPN_UID, exemptUid); assertContainsExactly(exemptUidCaptor.getValue(), Process.VPN_UID, exemptUid);
final int expectedNetId = mMockVpn.getNetwork() == null ? NETID_UNSET
: mMockVpn.getNetwork().getNetId();
if (add) { if (add) {
inOrder.verify(mMockNetd, times(1)).networkAddUidRanges(eq(mMockVpn.getNetId()), inOrder.verify(mMockNetd, times(1)).networkAddUidRanges(eq(expectedNetId),
eq(toUidRangeStableParcels(vpnRanges))); eq(toUidRangeStableParcels(vpnRanges)));
} else { } else {
inOrder.verify(mMockNetd, times(1)).networkRemoveUidRanges(eq(mMockVpn.getNetId()), inOrder.verify(mMockNetd, times(1)).networkRemoveUidRanges(eq(expectedNetId),
eq(toUidRangeStableParcels(vpnRanges))); eq(toUidRangeStableParcels(vpnRanges)));
} }