From ad26a418207607d65688cc5065199f8e2bb5ba5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Ciche=C5=84ski?= Date: Fri, 28 Jul 2023 00:29:04 +0000 Subject: [PATCH] Remove the flaky annotation and bring test to presubmit The issue has been fixed in http://ag/24235063 Change-Id: Ib4511fcdff6bca5f872a4030f497ef9275a23bce Test: atest com.android.wm.shell.flicker.pip.MovePipDownOnShelfHeightChange Bug: 292813143 --- .../shell/flicker/pip/MovePipDownOnShelfHeightChange.kt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/MovePipDownOnShelfHeightChange.kt b/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/MovePipDownOnShelfHeightChange.kt index 13aa758ff1194..5efa51b53970a 100644 --- a/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/MovePipDownOnShelfHeightChange.kt +++ b/libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/MovePipDownOnShelfHeightChange.kt @@ -16,7 +16,7 @@ package com.android.wm.shell.flicker.pip -import android.platform.test.annotations.FlakyTest +import android.platform.test.annotations.Presubmit import android.tools.device.flicker.junit.FlickerParametersRunnerFactory import android.tools.device.flicker.legacy.FlickerBuilder import android.tools.device.flicker.legacy.LegacyFlickerTest @@ -63,10 +63,12 @@ class MovePipDownOnShelfHeightChange(flicker: LegacyFlickerTest) : } /** Checks that the visible region of [pipApp] window always moves down during the animation. */ - @FlakyTest(bugId = 292813143) @Test fun pipWindowMovesDown() = pipWindowMoves(Direction.DOWN) + @Presubmit + @Test + fun pipWindowMovesDown() = pipWindowMoves(Direction.DOWN) /** Checks that the visible region of [pipApp] layer always moves down during the animation. */ - @FlakyTest(bugId = 292813143) + @Presubmit @Test fun pipLayerMovesDown() = pipLayerMoves(Direction.DOWN) }